You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/10/08 18:52:54 UTC

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #511: Expose partition spec info

aokolnychyi commented on a change in pull request #511: Expose partition spec info
URL: https://github.com/apache/incubator-iceberg/pull/511#discussion_r332676866
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/BaseMetadataTable.java
 ##########
 @@ -52,7 +55,17 @@ public void refresh() {
 
   @Override
   public PartitionSpec spec() {
-    return PartitionSpec.unpartitioned();
+    return spec;
+  }
+
+  @Override
+  public PartitionSpec spec(int specId) {
+    return spec.specId() == specId ? spec : null;
+  }
+
+  @Override
+  public Iterable<PartitionSpec> specs() {
 
 Review comment:
   Makes sense

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org