You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zeodtr <gi...@git.apache.org> on 2014/07/22 03:02:04 UTC

[GitHub] spark pull request: fixes https://issues.apache.org/jira/browse/SP...

Github user zeodtr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/899#discussion_r15206281
  
    --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -309,7 +310,7 @@ trait ClientBase extends Logging {
         // Add Xmx for AM memory
         JAVA_OPTS += "-Xmx" + amMemory + "m"
     
    -    val tmpDir = new Path(Environment.PWD.$(), YarnConfiguration.DEFAULT_CONTAINER_TEMP_DIR)
    +    val tmpDir = new Path(Environment.PWD.$$(), YarnConfiguration.DEFAULT_CONTAINER_TEMP_DIR)
    --- End diff --
    
    Can we have a new spark configuration variable, like "spark.yarn.submit.crossplatform"?
    If so, the code here can be applied conditionally "hard-coding" required separator, without using reflection.
    (But currently I my knowledge on Spark source code and Scala is limited to implement it myself.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---