You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 11:59:11 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #22849: Allow using mapped upstream's aggregated XCom

uranusjr commented on code in PR #22849:
URL: https://github.com/apache/airflow/pull/22849#discussion_r846039122


##########
tests/models/test_taskinstance.py:
##########
@@ -1091,7 +1092,7 @@ def test_xcom_pull_mapped(self, dag_maker, session):
         assert ti_2.xcom_pull("task_1", map_indexes=1, session=session) == "b"
 
         joined = ti_2.xcom_pull("task_1", session=session)
-        assert iter(joined) is joined, "should be iterator"
+        assert isinstance(joined, collections.abc.Iterable), "should be iterator"

Review Comment:
   ```suggestion
           assert isinstance(joined, collections.abc.Iterable), "should be iterable"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org