You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2021/07/27 06:10:18 UTC
Cutting 3.7.1 release?
Hello,
Is it time for a new 3.7.1 release ?
Personally I am very interested in delivering the great improvements to the
Prometheus metrics providers and the fixes to the ZooKeeper Embedded API.
If no one objects I would like to prepare a release within the end of this
month.
Please verify if there are open pull requests or commits that are good to
be cherry picked to the 3.7 branch.
Enrico
Re: Cutting 3.7.1 release?
Posted by Li Wang <li...@gmail.com>.
Hi Enrico,
Regarding the issue/patch https://github.com/apache/zookeeper/pull/1770, I
have some comments below.
Please let me know if anything I can help.
Best,
Li
On Tue, Jan 18, 2022 at 12:06 PM Enrico Olivelli <eo...@gmail.com>
wrote:
> Li,
>
> Il Ven 14 Gen 2022, 00:27 Li Wang <li...@gmail.com> ha scritto:
>
>> Hello,
>>
>> Any updates on the 3.7.1 release? There are some enhancements we would
>> like to pick up and they are not available in 3.7.0.
>>
>
> I wanted to see this patch committed
> https://github.com/apache/zookeeper/pull/1770
>
> Or, better, the problem fixed
>
Does the issue occur only when using the "ruok" command? Checking the code,
it seems to be applicable to other commands too. We use `srvr` command for
health-check in k8s env and didn't see the issue so far. If using the NIO
connection is not an option, are there other possible workarounds? For
example:
1. Using the admin http requests instead of the 4lw commands for health
check
2. Tuning the liveness and readiness probe properties
(e.g. InitialDelaySeconds, FailureThreshold, etc)
Please let me know if anything I can help on this.
>
> BTW the patch is not good to go so it is probably better to move forward
> with the release
>
> We will also start the release process for 3.8 that drops log4j 1.x
>
>
> Enrico
>
>
>
>> Thanks,
>>
>> Li
>>
>> On Wed, Jul 28, 2021 at 6:39 AM Damien Diederen <dd...@apache.org>
>> wrote:
>>
>>>
>>> Hi Enrico, all,
>>>
>>> > Is it time for a new 3.7.1 release ?
>>>
>>> Probably. I still haven't found enough time and/or energy to improve
>>> the test suite, but it certainly isn't in a worse state than when we
>>> cut 3.7.0.
>>>
>>> > Personally I am very interested in delivering the great improvements
>>> to the
>>> > Prometheus metrics providers and the fixes to the ZooKeeper Embedded
>>> API.
>>> >
>>> > If no one objects I would like to prepare a release within the end of
>>> this
>>> > month.
>>>
>>> Thank you for volunteering!
>>>
>>> > Please verify if there are open pull requests or commits that are good
>>> to
>>> > be cherry picked to the 3.7 branch.
>>>
>>> I don't have any outstanding points regarding this one—but you might
>>> want to re-review it:
>>>
>>> * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
>>> multi requests
>>> https://github.com/apache/zookeeper/pull/1559
>>>
>>> Cheers, -D
>>>
>>
Re: Cutting 3.7.1 release?
Posted by Enrico Olivelli <eo...@gmail.com>.
Li,
Il Ven 14 Gen 2022, 00:27 Li Wang <li...@gmail.com> ha scritto:
> Hello,
>
> Any updates on the 3.7.1 release? There are some enhancements we would
> like to pick up and they are not available in 3.7.0.
>
I wanted to see this patch committed
https://github.com/apache/zookeeper/pull/1770
Or, better, the problem fixed
BTW the patch is not good to go so it is probably better to move forward
with the release
We will also start the release process for 3.8 that drops log4j 1.x
Enrico
> Thanks,
>
> Li
>
> On Wed, Jul 28, 2021 at 6:39 AM Damien Diederen <dd...@apache.org>
> wrote:
>
>>
>> Hi Enrico, all,
>>
>> > Is it time for a new 3.7.1 release ?
>>
>> Probably. I still haven't found enough time and/or energy to improve
>> the test suite, but it certainly isn't in a worse state than when we
>> cut 3.7.0.
>>
>> > Personally I am very interested in delivering the great improvements to
>> the
>> > Prometheus metrics providers and the fixes to the ZooKeeper Embedded
>> API.
>> >
>> > If no one objects I would like to prepare a release within the end of
>> this
>> > month.
>>
>> Thank you for volunteering!
>>
>> > Please verify if there are open pull requests or commits that are good
>> to
>> > be cherry picked to the 3.7 branch.
>>
>> I don't have any outstanding points regarding this one—but you might
>> want to re-review it:
>>
>> * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
>> multi requests
>> https://github.com/apache/zookeeper/pull/1559
>>
>> Cheers, -D
>>
>
Re: Cutting 3.7.1 release?
Posted by Li Wang <li...@gmail.com>.
Hello,
Any updates on the 3.7.1 release? There are some enhancements we would like
to pick up and they are not available in 3.7.0.
Thanks,
Li
On Wed, Jul 28, 2021 at 6:39 AM Damien Diederen <dd...@apache.org>
wrote:
>
> Hi Enrico, all,
>
> > Is it time for a new 3.7.1 release ?
>
> Probably. I still haven't found enough time and/or energy to improve
> the test suite, but it certainly isn't in a worse state than when we
> cut 3.7.0.
>
> > Personally I am very interested in delivering the great improvements to
> the
> > Prometheus metrics providers and the fixes to the ZooKeeper Embedded API.
> >
> > If no one objects I would like to prepare a release within the end of
> this
> > month.
>
> Thank you for volunteering!
>
> > Please verify if there are open pull requests or commits that are good to
> > be cherry picked to the 3.7 branch.
>
> I don't have any outstanding points regarding this one—but you might
> want to re-review it:
>
> * ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
> multi requests
> https://github.com/apache/zookeeper/pull/1559
>
> Cheers, -D
>
Re: Cutting 3.7.1 release?
Posted by Damien Diederen <dd...@apache.org>.
Hi Enrico, all,
> Is it time for a new 3.7.1 release ?
Probably. I still haven't found enough time and/or energy to improve
the test suite, but it certainly isn't in a worse state than when we
cut 3.7.0.
> Personally I am very interested in delivering the great improvements to the
> Prometheus metrics providers and the fixes to the ZooKeeper Embedded API.
>
> If no one objects I would like to prepare a release within the end of this
> month.
Thank you for volunteering!
> Please verify if there are open pull requests or commits that are good to
> be cherry picked to the 3.7 branch.
I don't have any outstanding points regarding this one—but you might
want to re-review it:
* ZOOKEEPER-4026: Complete support for Stat objects (and create2) in
multi requests
https://github.com/apache/zookeeper/pull/1559
Cheers, -D
Re: Cutting 3.7.1 release?
Posted by Enrico Olivelli <eo...@gmail.com>.
Li
Il Mar 27 Lug 2021, 22:44 Li Wang <li...@gmail.com> ha scritto:
> Hi Enrico,
>
> That's great! Looking forward to the 3.7.1 release.
>
> Can we get the following two Prometheus metrics related PRs into the 3.7
> branch, so we can have them in our 3.7 prod rollout? They have been
> approved and the next step is to merge.
> https://github.com/apache/zookeeper/pull/1644 (ZOOKEEPER-4211: Expose
> Quota
> Metrics to Prometheus)
> https://github.com/apache/zookeeper/pull/1698 (ZOOKEEPER-4289: Reduce the
> performance impact of Prometheus metrics)
>
4289 is exactly what I would like to deliver with 3.7
I am not sure that 1644 fits a point release, I will double check
Enrico
> Please let me know if you have any questions or need any help.
>
> Thanks,
>
> Li
>
>
>
>
> On Mon, Jul 26, 2021 at 11:11 PM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Hello,
> > Is it time for a new 3.7.1 release ?
> >
> > Personally I am very interested in delivering the great improvements to
> the
> > Prometheus metrics providers and the fixes to the ZooKeeper Embedded API.
> >
> > If no one objects I would like to prepare a release within the end of
> this
> > month.
> >
> > Please verify if there are open pull requests or commits that are good to
> > be cherry picked to the 3.7 branch.
> >
> >
> > Enrico
> >
>
Re: Cutting 3.7.1 release?
Posted by Li Wang <li...@gmail.com>.
Hi Enrico,
That's great! Looking forward to the 3.7.1 release.
Can we get the following two Prometheus metrics related PRs into the 3.7
branch, so we can have them in our 3.7 prod rollout? They have been
approved and the next step is to merge.
https://github.com/apache/zookeeper/pull/1644 (ZOOKEEPER-4211: Expose Quota
Metrics to Prometheus)
https://github.com/apache/zookeeper/pull/1698 (ZOOKEEPER-4289: Reduce the
performance impact of Prometheus metrics)
Please let me know if you have any questions or need any help.
Thanks,
Li
On Mon, Jul 26, 2021 at 11:11 PM Enrico Olivelli <eo...@gmail.com>
wrote:
> Hello,
> Is it time for a new 3.7.1 release ?
>
> Personally I am very interested in delivering the great improvements to the
> Prometheus metrics providers and the fixes to the ZooKeeper Embedded API.
>
> If no one objects I would like to prepare a release within the end of this
> month.
>
> Please verify if there are open pull requests or commits that are good to
> be cherry picked to the 3.7 branch.
>
>
> Enrico
>