You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/10/20 21:20:39 UTC
Review Request 63191: Refactored entering the chroot in the container
launch.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63191/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Hoisted the platform-dependent chroot code out into a helper function
to improve readability. Improved the error message to always include
the rootfs we attempted to enter.
Diffs
-----
src/slave/containerizer/mesos/launch.cpp d1372987cfbd3761d344479992b2ca6bb918540c
Diff: https://reviews.apache.org/r/63191/diff/1/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 63191: Refactored entering the chroot in the
container launch.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63191/#review188872
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Oct. 20, 2017, 9:20 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63191/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2017, 9:20 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Hoisted the platform-dependent chroot code out into a helper function
> to improve readability. Improved the error message to always include
> the rootfs we attempted to enter.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp d1372987cfbd3761d344479992b2ca6bb918540c
>
>
> Diff: https://reviews.apache.org/r/63191/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>