You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2013/06/13 11:48:18 UTC

[06/11] git commit: full test webpagerender method for current implementation state

full test webpagerender method for current implementation state


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0d284b57
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0d284b57
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0d284b57

Branch: refs/heads/master
Commit: 0d284b577afc114ebc21da0c0be3292064fc02fd
Parents: 96e0bab
Author: Michael Mosmann <mi...@mosmann.de>
Authored: Thu Sep 27 00:07:30 2012 +0200
Committer: Michael Mosmann <mi...@mosmann.de>
Committed: Thu Sep 27 00:07:30 2012 +0200

----------------------------------------------------------------------
 ...ShouldRenderPageAndWriteResponseVariations.java | 17 +++++++++++++++++
 .../handler/render/WebPageRendererTest.java        |  3 +--
 2 files changed, 18 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/0d284b57/wicket-core/src/test/java/org/apache/wicket/request/handler/render/ShouldRenderPageAndWriteResponseVariations.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/request/handler/render/ShouldRenderPageAndWriteResponseVariations.java b/wicket-core/src/test/java/org/apache/wicket/request/handler/render/ShouldRenderPageAndWriteResponseVariations.java
index 65f9b0c..f1bad05 100644
--- a/wicket-core/src/test/java/org/apache/wicket/request/handler/render/ShouldRenderPageAndWriteResponseVariations.java
+++ b/wicket-core/src/test/java/org/apache/wicket/request/handler/render/ShouldRenderPageAndWriteResponseVariations.java
@@ -42,4 +42,21 @@ public class ShouldRenderPageAndWriteResponseVariations {
 	public void nextVariation() {
 		last.nextVariation();
 	}
+
+	public String toString() {
+		StringBuilder sb=new StringBuilder();
+		toString(sb,"ajax",ajax);
+		toString(sb,"onePassRender",onePassRender);
+		toString(sb,"redirectToRender",redirectToRender);
+		toString(sb,"redirectPolicy",redirectPolicy);
+		toString(sb,"shouldPreserveClientUrl",shouldPreserveClientUrl);
+		toString(sb,"targetEqualsCurrentUrl",targetEqualsCurrentUrl);
+		toString(sb,"newPageInstance",newPageInstance);
+		toString(sb,"pageStateless",pageStateless);
+		return sb.toString();
+	}
+
+	static void toString(StringBuilder sb,String label, VariationIterator<?> iterator) {
+		sb.append(label).append("=").append(iterator.value()).append(",");
+	}
 }

http://git-wip-us.apache.org/repos/asf/wicket/blob/0d284b57/wicket-core/src/test/java/org/apache/wicket/request/handler/render/WebPageRendererTest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/request/handler/render/WebPageRendererTest.java b/wicket-core/src/test/java/org/apache/wicket/request/handler/render/WebPageRendererTest.java
index 75dfecf..47022a3 100644
--- a/wicket-core/src/test/java/org/apache/wicket/request/handler/render/WebPageRendererTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/request/handler/render/WebPageRendererTest.java
@@ -803,8 +803,7 @@ public class WebPageRendererTest
 
 		ShouldRenderPageAndWriteResponseVariations variations=new ShouldRenderPageAndWriteResponseVariations();
 		while (variations.hasNextVariation()) {
-			char c = variations.getResult() ? 'X' : ' ';
-			Assert.assertEquals(match.charAt(idx),c);
+			Assert.assertEquals(variations.toString(), match.charAt(idx) == 'X',variations.getResult());
 			variations.nextVariation();
 			idx++;
 		}