You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aromanenko-dev (via GitHub)" <gi...@apache.org> on 2023/01/23 18:00:32 UTC

[GitHub] [beam] aromanenko-dev opened a new issue, #25120: [Task]: Add unit tests for JdbcSchemaIOProvider

aromanenko-dev opened a new issue, #25120:
URL: https://github.com/apache/beam/issues/25120

   ### What needs to happen?
   
   To test a basic functionality and avoid breaking changes `JdbcSchemaIOProvider` should be tested by unit tests. 
   
   ### Issue Priority
   
   Priority: 3 (nice-to-have improvement)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [X] Component: Java SDK
   - [ ] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [ ] Component: IO connector
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] olalamichelle commented on issue #25120: [Task]: Add unit tests for JdbcSchemaIOProvider

Posted by "olalamichelle (via GitHub)" <gi...@apache.org>.
olalamichelle commented on issue #25120:
URL: https://github.com/apache/beam/issues/25120#issuecomment-1694519110

   I have opened a PR https://github.com/apache/beam/pull/28174. There was actually a bug in the SchemaIOProvider that the maxConnections was Short in the config but read back as Integer. I fixed it also added unit tests for it to prevent similar breaking changes described in this ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] closed issue #25120: [Task]: Add unit tests for JdbcSchemaIOProvider

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #25120: [Task]: Add unit tests for JdbcSchemaIOProvider
URL: https://github.com/apache/beam/issues/25120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] olalamichelle commented on issue #25120: [Task]: Add unit tests for JdbcSchemaIOProvider

Posted by "olalamichelle (via GitHub)" <gi...@apache.org>.
olalamichelle commented on issue #25120:
URL: https://github.com/apache/beam/issues/25120#issuecomment-1694511608

   .take-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] olalamichelle commented on issue #25120: [Task]: Add unit tests for JdbcSchemaIOProvider

Posted by "olalamichelle (via GitHub)" <gi...@apache.org>.
olalamichelle commented on issue #25120:
URL: https://github.com/apache/beam/issues/25120#issuecomment-1698415978

   .close-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on issue #25120: [Task]: Add unit tests for JdbcSchemaIOProvider

Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on issue #25120:
URL: https://github.com/apache/beam/issues/25120#issuecomment-1706913189

   @olalamichelle Thanks for taking care of this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org