You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/06 20:54:32 UTC
[GitHub] [skywalking-eyes] steveklabnik opened a new pull request #87: Add MPL-2.0 header template
steveklabnik opened a new pull request #87:
URL: https://github.com/apache/skywalking-eyes/pull/87
Hi there, thanks for this great project! I am using the MPL in some places, and so would love built-in support for it. It's really nice that it was so easy to use a `content` block to get started, but I figured upstreaming this would be nice :)
I am not sure if I should be adding a test or anything, happy to make any modifications you'd like. I did verify that this works by running my branch against a sample codebase, you can see that result here: https://github.com/steveklabnik/ci-license-test/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on a change in pull request #87: Add MPL-2.0 header template
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #87:
URL: https://github.com/apache/skywalking-eyes/pull/87#discussion_r779980947
##########
File path: assets/header-templates/MPL-2.0.txt
##########
@@ -0,0 +1,3 @@
+This Source Code Form is subject to the terms of the Mozilla Public
+License, v. 2.0. If a copy of the MPL was not distributed with this
+file, You can obtain one at https://mozilla.org/MPL/2.0/.
Review comment:
I can confirm the content of this header matches the official version, https://www.mozilla.org/en-US/MPL/headers/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] MoGuGuai-hzr commented on pull request #87: Add MPL-2.0 header template
Posted by GitBox <gi...@apache.org>.
MoGuGuai-hzr commented on pull request #87:
URL: https://github.com/apache/skywalking-eyes/pull/87#issuecomment-1008655834
Putting `MPL-2.0` header template into `assets/header-templates` is a simplified solution which specifies the license header content in `.licenserc.yaml`. But remember, you still need to specify `spdx-id` of the license in `.licenserc.yaml`.
The current test has not considered other headers except `apache-2.0`. You can find the unit test `TestCheckFile` at in `pkg/header/check_test.go`. It uses a default `ConfigHeader` which will test `apache-2.0` only.
In order to support other headers, maybe you should modify it and add some test data in `test/testdata/**`. In addition, the current test data is also only for `apache-2.0`, in order to deal with other headers, you may modify the directory structure of the test data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on pull request #87: Add MPL-2.0 header template
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #87:
URL: https://github.com/apache/skywalking-eyes/pull/87#issuecomment-1007016164
I have assigned the reviewer, but he has some personal stuff for 2 weeks. So this PR will be pending a little longer than usual.Please wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on pull request #87: Add MPL-2.0 header template
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #87:
URL: https://github.com/apache/skywalking-eyes/pull/87#issuecomment-1014079627
Thank you @steveklabnik for opening this PR and @MoGuGuai-hzr for reviewing!!!
The changes looks good to me. As for the tests, now we just want to test the mechanism that finding license header and comparing the header works, adding tests for each license might be boring and duplicating so I don't require (nor reject) it if anyone would like to add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 merged pull request #87: Add MPL-2.0 header template
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #87:
URL: https://github.com/apache/skywalking-eyes/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org