You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/03/04 20:34:24 UTC
[GitHub] [commons-lang] kinow commented on a change in pull request #410:
Add proposal for Jenkins Pipeline
kinow commented on a change in pull request #410: Add proposal for Jenkins Pipeline
URL: https://github.com/apache/commons-lang/pull/410#discussion_r262231301
##########
File path: Jenkinsfile
##########
@@ -43,11 +43,7 @@ pipeline {
}
stage('Analyze') {
steps {
- sh 'mvn apache-rat:check'
- sh 'mvn clirr:check'
- sh 'mvn checkstyle:check'
- sh 'mvn spotbugs:check'
- sh 'mvn javadoc:javadoc'
+ sh 'mvn apache-rat:check clirr:check checkstyle:check spotbugs:check javadoc:javadoc'
Review comment:
Might be a good idea. I think in Travis we have that in some other components too... that way once updated, we won't have to touch the Jenkinsfile (which I'm less familiar than pom.xml). Or would there be some advantage in maintaining the build maven goals in the Jenkinsfile instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services