[jira] Closed: (FELIX-473) ClassCastException in org.apache.felix.shell ShellServiceImpl getCommandReference

["Nektarios K. Papadopoulos (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FELIX-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nektarios K. Papadopoulos closed FELIX-473.
-------------------------------------------


> ClassCastException in org.apache.felix.shell ShellServiceImpl getCommandReference
> ---------------------------------------------------------------------------------
>
>                 Key: FELIX-473
>                 URL: https://issues.apache.org/jira/browse/FELIX-473
>             Project: Felix
>          Issue Type: Bug
>            Reporter: Nektarios K. Papadopoulos
>            Assignee: Richard S. Hall
>            Priority: Minor
>         Attachments: getCommandReference.patch
>
>
> The implementation is obviously wrong, since m_commandNameMap contains Command object, not ServiceReference ones.
> The bug is inherited from Oscar, but the resolution would have been cleaner back then, since the ServiceReference was readily available in the (now abandoned) CommandRecord objects the Map used to hold.
> Nevertheless, the solution is to iterate through the Map.Entry's of the m_commandRefMap entrySet and compare the command names one by one.
> Apparently no one ever uses this method, so the complexity/performance-penalty of the suggested solution is not an issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.