You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bf...@apache.org on 2013/02/07 21:04:12 UTC
[25/51] [abbrv] git commit: refs/heads/ui-plugins - Summary: Fix NPE
when calling createFirewallRule
Summary: Fix NPE when calling createFirewallRule
Detail: CreateFirewallRuleCmd.java was returning 'null' for getTrafficType().
Recently, getTrafficType started being used by createIngressFirewallRule.
Changing getTrafficType() to return ingress per Jayapal Reddy.
BUG-ID: CLOUDSTACK-1168
Bugfix-for: master,4.1
Signed-off-by: Marcus Sorensen <ma...@betterservers.com> 1360170916 -0700
Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/ec6fdc74
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/ec6fdc74
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/ec6fdc74
Branch: refs/heads/ui-plugins
Commit: ec6fdc7471a327a30c16426012a6132fab4e40a2
Parents: dc7578c
Author: Marcus Sorensen <ma...@betterservers.com>
Authored: Wed Feb 6 10:15:16 2013 -0700
Committer: Marcus Sorensen <ma...@betterservers.com>
Committed: Wed Feb 6 10:15:16 2013 -0700
----------------------------------------------------------------------
.../user/firewall/CreateFirewallRuleCmd.java | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/ec6fdc74/api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
----------------------------------------------------------------------
diff --git a/api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java b/api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
index d0c49ff..b7cb471 100644
--- a/api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
+++ b/api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java
@@ -324,7 +324,7 @@ public class CreateFirewallRuleCmd extends BaseAsyncCreateCmd implements Firewal
@Override
public TrafficType getTrafficType() {
- return null;
+ return FirewallRule.TrafficType.Ingress;
}
}