You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by si...@apache.org on 2011/11/14 14:47:07 UTC

svn commit: r1201702 - /maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm

Author: simonetripodi
Date: Mon Nov 14 13:47:06 2011
New Revision: 1201702

URL: http://svn.apache.org/viewvc?rev=1201702&view=rev
Log:
restored the default css importing policy
restored the missing site.css for extension points

Modified:
    maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm

Modified: maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm?rev=1201702&r1=1201701&r2=1201702&view=diff
==============================================================================
--- maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm (original)
+++ maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm Mon Nov 14 13:47:06 2011
@@ -507,7 +507,12 @@
   <head>
     <meta http-equiv="Content-Type" content="text/html; charset=${outputEncoding}" />
     <title>$title</title>
-    <link rel="stylesheet" href="$relativePath/css/bootstrap-1.3.0.min.css" />
+    <style type="text/css" media="all">
+      @import url("$relativePath/css/bootstrap-1.3.0.min.css");
+      @import url("$relativePath/css/maven-base.css");
+      @import url("$relativePath/css/maven-theme.css");
+      @import url("$relativePath/css/site.css");
+    </style>
     #if ( $decoration.custom.getChild( 'fluidoSkin' )
               && $decoration.custom.getChild( 'fluidoSkin' ).getChild( 'topBarEnabled' )
               && 'true' == $decoration.custom.getChild( 'fluidoSkin' ).getChild( 'topBarEnabled' ).getValue() )
@@ -516,8 +521,6 @@
     #else
     <style>body{padding-top: 20px;}</style>
     #end
-    <link rel="stylesheet" href="$relativePath/css/maven-base.css" />
-    <link rel="stylesheet" href="$relativePath/css/maven-theme.css" />
 
     #if ( $decoration.body.head )
       #foreach( $item in $decoration.body.head.getChildren() )

Re: svn commit: r1201702 - /maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm

Posted by Ivan Habunek <iv...@gmail.com>.
On 14 November 2011 21:19, Simone Tripodi <si...@apache.org> wrote:
> AMAZING Ivan!!!
> does it work with JS as well?

Yup. JS and CSS. Just be careful to test it out before deploying.
Sometimes it acts a little bit quirky in my experience.

Regards,
Ivan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

RE: svn commit: r1201702 - /maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm

Posted by Robert Scholte <rf...@codehaus.org>.
Yes it does, here's another example: http://alchim.sourceforge.net/yuicompressor-maven-plugin/index.html

Just pick your favorite.

 

-Robert

----------------------------------------
> Date: Mon, 14 Nov 2011 21:19:26 +0100
> Subject: Re: svn commit: r1201702 - /maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
> From: simonetripodi@apache.org
> To: dev@maven.apache.org
>
> AMAZING Ivan!!!
> does it work with JS as well?
> TIA,
> Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
>
> On Mon, Nov 14, 2011 at 9:08 PM, Ivan Habunek <iv...@gmail.com> wrote:
> > You can use maven minify plugin [1] to combine all CSS files into one
> > (and minify them along the way). I tried it for the log4php web site
> > and it seems to work pretty well.
> >
> > [1] http://maven-samaxes-plugin.googlecode.com/svn/sites/maven-minify-plugin/usage.html
> >
> > Regards,
> > Ivan
> >
> > On 14 November 2011 21:01, Simone Tripodi <si...@apache.org> wrote:
> >> Hi Robert!
> >> that's my bad, I originally had links then switched to import to quick
> >> reintroduce the site.css... then stumbled in the side effect of c'n'p
> >> :(
> >> Going to come back to links, thanks for the hint!!!
> >> All the best,
> >> Simo
> >>
> >> http://people.apache.org/~simonetripodi/
> >> http://simonetripodi.livejournal.com/
> >> http://twitter.com/simonetripodi
> >> http://www.99soft.org/
> >>
> >>
> >>
> >> On Mon, Nov 14, 2011 at 6:48 PM, Robert Scholte <rf...@codehaus.org> wrote:
> >>>
> >>> Hi Simone,
> >>>
> >>>
> >>>
> >>> recently I've been working on website performance improvements and you just hit another issue:
> >>>
> >>> "Don't use import"[1]
> >>>
> >>> We wanted to make only one call for css, so I wrote a small groovy-script which bundled all imports.
> >>>
> >>> I still have to make write a maven-plugin for it.
> >>>
> >>> So it's up to you: use links or bundle them. This is really a response-killer, more than I could imagine!
> >>>
> >>>
> >>>
> >>> -Robert
> >>>
> >>>
> >>>
> >>> [1] http://www.stevesouders.com/blog/2009/04/09/dont-use-import/
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 		 	   		  
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r1201702 - /maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm

Posted by Simone Tripodi <si...@apache.org>.
AMAZING Ivan!!!
does it work with JS as well?
TIA,
Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Mon, Nov 14, 2011 at 9:08 PM, Ivan Habunek <iv...@gmail.com> wrote:
> You can use maven minify plugin [1] to combine all CSS files into one
> (and minify them along the way). I tried it for the log4php web site
> and it seems to work pretty well.
>
> [1] http://maven-samaxes-plugin.googlecode.com/svn/sites/maven-minify-plugin/usage.html
>
> Regards,
> Ivan
>
> On 14 November 2011 21:01, Simone Tripodi <si...@apache.org> wrote:
>> Hi Robert!
>> that's my bad, I originally had links then switched to import to quick
>> reintroduce the site.css... then stumbled in the side effect of c'n'p
>> :(
>> Going to come back to links, thanks for the hint!!!
>> All the best,
>> Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>>
>>
>> On Mon, Nov 14, 2011 at 6:48 PM, Robert Scholte <rf...@codehaus.org> wrote:
>>>
>>> Hi Simone,
>>>
>>>
>>>
>>> recently I've been working on website performance improvements and you just hit another issue:
>>>
>>> "Don't use import"[1]
>>>
>>> We wanted to make only one call for css, so I wrote a small groovy-script which bundled all imports.
>>>
>>> I still have to make write a maven-plugin for it.
>>>
>>> So it's up to you: use links or bundle them. This is really a response-killer, more than I could imagine!
>>>
>>>
>>>
>>> -Robert
>>>
>>>
>>>
>>> [1] http://www.stevesouders.com/blog/2009/04/09/dont-use-import/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r1201702 - /maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm

Posted by Ivan Habunek <iv...@gmail.com>.
You can use maven minify plugin [1] to combine all CSS files into one
(and minify them along the way). I tried it for the log4php web site
and it seems to work pretty well.

[1] http://maven-samaxes-plugin.googlecode.com/svn/sites/maven-minify-plugin/usage.html

Regards,
Ivan

On 14 November 2011 21:01, Simone Tripodi <si...@apache.org> wrote:
> Hi Robert!
> that's my bad, I originally had links then switched to import to quick
> reintroduce the site.css... then stumbled in the side effect of c'n'p
> :(
> Going to come back to links, thanks for the hint!!!
> All the best,
> Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
>
> On Mon, Nov 14, 2011 at 6:48 PM, Robert Scholte <rf...@codehaus.org> wrote:
>>
>> Hi Simone,
>>
>>
>>
>> recently I've been working on website performance improvements and you just hit another issue:
>>
>> "Don't use import"[1]
>>
>> We wanted to make only one call for css, so I wrote a small groovy-script which bundled all imports.
>>
>> I still have to make write a maven-plugin for it.
>>
>> So it's up to you: use links or bundle them. This is really a response-killer, more than I could imagine!
>>
>>
>>
>> -Robert
>>
>>
>>
>> [1] http://www.stevesouders.com/blog/2009/04/09/dont-use-import/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r1201702 - /maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm

Posted by Simone Tripodi <si...@apache.org>.
Hi Robert!
that's my bad, I originally had links then switched to import to quick
reintroduce the site.css... then stumbled in the side effect of c'n'p
:(
Going to come back to links, thanks for the hint!!!
All the best,
Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Mon, Nov 14, 2011 at 6:48 PM, Robert Scholte <rf...@codehaus.org> wrote:
>
> Hi Simone,
>
>
>
> recently I've been working on website performance improvements and you just hit another issue:
>
> "Don't use import"[1]
>
> We wanted to make only one call for css, so I wrote a small groovy-script which bundled all imports.
>
> I still have to make write a maven-plugin for it.
>
> So it's up to you: use links or bundle them. This is really a response-killer, more than I could imagine!
>
>
>
> -Robert
>
>
>
> [1] http://www.stevesouders.com/blog/2009/04/09/dont-use-import/
>
>
>
> http://www.stevesouders.com/blog/2009/04/09/dont-use-import/----------------------------------------
>> Subject: svn commit: r1201702 - /maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
>> Date: Mon, 14 Nov 2011 13:47:07 +0000
>> To: commits@maven.apache.org
>> From: simonetripodi@apache.org
>>
>> Author: simonetripodi
>> Date: Mon Nov 14 13:47:06 2011
>> New Revision: 1201702
>>
>> URL: http://svn.apache.org/viewvc?rev=1201702&view=rev
>> Log:
>> restored the default css importing policy
>> restored the missing site.css for extension points
>>
>> Modified:
>> maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
>>
>> Modified: maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
>> URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm?rev=1201702&r1=1201701&r2=1201702&view=diff
>> ==============================================================================
>> --- maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm (original)
>> +++ maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm Mon Nov 14 13:47:06 2011
>> @@ -507,7 +507,12 @@
>> <head>
>> <meta http-equiv="Content-Type" content="text/html; charset=${outputEncoding}" />
>> <title>$title</title>
>> - <link rel="stylesheet" href="$relativePath/css/bootstrap-1.3.0.min.css" />
>> + <style type="text/css" media="all">
>> + @import url("$relativePath/css/bootstrap-1.3.0.min.css");
>> + @import url("$relativePath/css/maven-base.css");
>> + @import url("$relativePath/css/maven-theme.css");
>> + @import url("$relativePath/css/site.css");
>> + </style>
>> #if ( $decoration.custom.getChild( 'fluidoSkin' )
>> && $decoration.custom.getChild( 'fluidoSkin' ).getChild( 'topBarEnabled' )
>> && 'true' == $decoration.custom.getChild( 'fluidoSkin' ).getChild( 'topBarEnabled' ).getValue() )
>> @@ -516,8 +521,6 @@
>> #else
>> <style>body{padding-top: 20px;}</style>
>> #end
>> - <link rel="stylesheet" href="$relativePath/css/maven-base.css" />
>> - <link rel="stylesheet" href="$relativePath/css/maven-theme.css" />
>>
>> #if ( $decoration.body.head )
>> #foreach( $item in $decoration.body.head.getChildren() )
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

RE: svn commit: r1201702 - /maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm

Posted by Robert Scholte <rf...@codehaus.org>.
Hi Simone,

 

recently I've been working on website performance improvements and you just hit another issue:

"Don't use import"[1]

We wanted to make only one call for css, so I wrote a small groovy-script which bundled all imports. 

I still have to make write a maven-plugin for it.

So it's up to you: use links or bundle them. This is really a response-killer, more than I could imagine!

 

-Robert

 

[1] http://www.stevesouders.com/blog/2009/04/09/dont-use-import/



http://www.stevesouders.com/blog/2009/04/09/dont-use-import/----------------------------------------
> Subject: svn commit: r1201702 - /maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
> Date: Mon, 14 Nov 2011 13:47:07 +0000
> To: commits@maven.apache.org
> From: simonetripodi@apache.org
>
> Author: simonetripodi
> Date: Mon Nov 14 13:47:06 2011
> New Revision: 1201702
>
> URL: http://svn.apache.org/viewvc?rev=1201702&view=rev
> Log:
> restored the default css importing policy
> restored the missing site.css for extension points
>
> Modified:
> maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
>
> Modified: maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm
> URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm?rev=1201702&r1=1201701&r2=1201702&view=diff
> ==============================================================================
> --- maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm (original)
> +++ maven/sandbox/trunk/skin/maven-fluido-skin/src/main/resources/META-INF/maven/site.vm Mon Nov 14 13:47:06 2011
> @@ -507,7 +507,12 @@
> <head>
> <meta http-equiv="Content-Type" content="text/html; charset=${outputEncoding}" />
> <title>$title</title>
> - <link rel="stylesheet" href="$relativePath/css/bootstrap-1.3.0.min.css" />
> + <style type="text/css" media="all">
> + @import url("$relativePath/css/bootstrap-1.3.0.min.css");
> + @import url("$relativePath/css/maven-base.css");
> + @import url("$relativePath/css/maven-theme.css");
> + @import url("$relativePath/css/site.css");
> + </style>
> #if ( $decoration.custom.getChild( 'fluidoSkin' )
> && $decoration.custom.getChild( 'fluidoSkin' ).getChild( 'topBarEnabled' )
> && 'true' == $decoration.custom.getChild( 'fluidoSkin' ).getChild( 'topBarEnabled' ).getValue() )
> @@ -516,8 +521,6 @@
> #else
> <style>body{padding-top: 20px;}</style>
> #end
> - <link rel="stylesheet" href="$relativePath/css/maven-base.css" />
> - <link rel="stylesheet" href="$relativePath/css/maven-theme.css" />
>
> #if ( $decoration.body.head )
> #foreach( $item in $decoration.body.head.getChildren() )
>
> 		 	   		  
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org