You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2022/10/12 10:24:38 UTC

[GitHub] [storm] s024wh opened a new pull request, #3496: fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0

s024wh opened a new pull request, #3496:
URL: https://github.com/apache/storm/pull/3496

   ### What happened？
   There are 4 security vulnerabilities found in org.apache.thrift:libthrift 0.9.3
   - [CVE-2018-1320](https://www.oscs1024.com/hd/CVE-2018-1320)
   - [CVE-2019-0205](https://www.oscs1024.com/hd/CVE-2019-0205)
   - [CVE-2018-11798](https://www.oscs1024.com/hd/CVE-2018-11798)
   - [CVE-2020-13949](https://www.oscs1024.com/hd/CVE-2020-13949)
   
   
   ### What did I do？
   Upgrade org.apache.thrift:libthrift from 0.9.3 to 0.14.0 for vulnerability fix
   
   ### What did you expect to happen？
   Ideally, no insecure libs should be used.
   
   ### The specification of the pull request
   [PR Specification](https://www.oscs1024.com/docs/pr-specification/) from OSCS


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [storm] bipinprasad commented on a diff in pull request #3496: fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0

Posted by GitBox <gi...@apache.org>.
bipinprasad commented on code in PR #3496:
URL: https://github.com/apache/storm/pull/3496#discussion_r1002255399


##########
external/storm-hive/pom.xml:
##########
@@ -202,7 +201,7 @@
         <!-- Needed in this version by hive -->
       <groupId>org.apache.thrift</groupId>
       <artifactId>libthrift</artifactId>
-      <version>0.9.3</version>
+      <version>0.14.0</version>

Review Comment:
   Can this use ${thrift.version}



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0 (storm)

Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 closed pull request #3496: fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0
URL: https://github.com/apache/storm/pull/3496


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [storm] bipinprasad commented on pull request #3496: fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0

Posted by GitBox <gi...@apache.org>.
bipinprasad commented on PR #3496:
URL: https://github.com/apache/storm/pull/3496#issuecomment-1287558076

   This will need some code change: change class 
         org.apache.storm.thrift.transport.TFramedTransport --> org.apache.storm.thrift.transport.layered.TFramedTransport
   And some other minor signature changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0 (storm)

Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3496:
URL: https://github.com/apache/storm/pull/3496#issuecomment-1678966913

   superseeded by https://github.com/apache/storm/pull/3564


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org