[PR] Handle empty values for task and datasource conditions in pod template selector (druid)

["kirangadhave-imply (via GitHub)" <gi...@apache.org>]

kirangadhave-imply opened a new pull request, #17399:
URL: https://github.com/apache/druid/pull/17399

   ### Description
   
   The condition based selector that evaluates tasks based on specified criteria failed to handle empty values for task type or datasource. If the condition is empty or null it can be matched to any task, but previous logic checked for task type or task datasource in the empty set resulting in skipping of that selector. Expected behavior is to treat empty sets the same as null.
   Fixed the evaluate method in Selector to check if the task type or datasource conditions are null or empty instead of just a null check.
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [ ] been tested in a test Druid cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

Re: [PR] Handle empty values for task and datasource conditions in pod template selector (druid)

["kirangadhave-imply (via GitHub)" <gi...@apache.org>]

kirangadhave-imply closed pull request #17399: Handle empty values for task and datasource conditions in pod template selector
URL: https://github.com/apache/druid/pull/17399


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org