You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Daniel Estévez <no...@github.com> on 2018/05/15 20:54:41 UTC

[jclouds/jclouds] Fixes assert for IpPermissions collection (#1209)

Azure does not return IpPermissions in order so this test fails randomly
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1209

-- Commit Summary --

  * Fixes assert for IpPermissions collection

-- File Changes --

    M providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/compute/extensions/AzureComputeSecurityGroupExtensionLiveTest.java (4)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1209.patch
https://github.com/jclouds/jclouds/pull/1209.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1209

Re: [jclouds/jclouds] Fixes assert for IpPermissions collection (#1209)

Posted by Ignasi Barrera <no...@github.com>.

Thanks @danielestevez! Can you check and fix the checkstyle violations in the ARM provider?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1209#issuecomment-389469592

Re: [jclouds/jclouds] Fixes assert for IpPermissions collection (#1209)

Posted by Daniel Estévez <no...@github.com>.

Fail!... and fixed!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1209#issuecomment-389517489

Re: [jclouds/jclouds] Fixes assert for IpPermissions collection (#1209)

Posted by Ignasi Barrera <no...@github.com>.

Closed #1209.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1209#event-1631251748

Re: [jclouds/jclouds] Fixes assert for IpPermissions collection (#1209)

Posted by Ignasi Barrera <no...@github.com>.

Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a918550e) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/6edb99c6).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1209#issuecomment-389768857