You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Henning Schmiedehausen (JIRA)" <ji...@apache.org> on 2008/05/21 22:55:55 UTC
[jira] Created: (SHINDIG-297) Split non-servlet parts of the
JsServlet out
Split non-servlet parts of the JsServlet out
--------------------------------------------
Key: SHINDIG-297
URL: https://issues.apache.org/jira/browse/SHINDIG-297
Project: Shindig
Issue Type: Improvement
Components: Common Components (Java)
Reporter: Henning Schmiedehausen
Attachments: jsserver.patch
Over here, we are using parts of the Shindig code base not through servlets but by other means (using RESTlets, to be exact). Some functionality of Shindig is inside the Servlets and this is hard to use if you don't actually have a servlet container to deploy these to.
The attached patch splits the JsServlet into two parts, JsServlet keeps all the functionality that is servlet specfic and everything else gets moved into JsServer, which contains the Shindig/Javascript specific code. JsServer then gets injected by Guice into the Servlet.
This patch assumes that SHINDIG-294 and SHINDIG-296 are applied.
the patch applies to the current trunk directory with "-p2"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-297) Split non-servlet parts of the
JsServlet out
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown updated SHINDIG-297:
--------------------------------
Component/s: (was: Common Components (Java))
Gadget Rendering Server (Java)
Fixing categorization.
This is still a good idea -- but needs more work to clean up the various servlets.
> Split non-servlet parts of the JsServlet out
> --------------------------------------------
>
> Key: SHINDIG-297
> URL: https://issues.apache.org/jira/browse/SHINDIG-297
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (Java)
> Reporter: Henning Schmiedehausen
> Attachments: jsserver.patch, shindig-297-2.patch
>
>
> Over here, we are using parts of the Shindig code base not through servlets but by other means (using RESTlets, to be exact). Some functionality of Shindig is inside the Servlets and this is hard to use if you don't actually have a servlet container to deploy these to.
> The attached patch splits the JsServlet into two parts, JsServlet keeps all the functionality that is servlet specfic and everything else gets moved into JsServer, which contains the Shindig/Javascript specific code. JsServer then gets injected by Guice into the Servlet.
> This patch assumes that SHINDIG-294 and SHINDIG-296 are applied.
> the patch applies to the current trunk directory with "-p2"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-297) Split non-servlet parts of the
JsServlet out
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen updated SHINDIG-297:
-------------------------------------------
Attachment: jsserver.patch
patch to factor out JsServer from JsServlet. Apply with "-p2"
> Split non-servlet parts of the JsServlet out
> --------------------------------------------
>
> Key: SHINDIG-297
> URL: https://issues.apache.org/jira/browse/SHINDIG-297
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Henning Schmiedehausen
> Attachments: jsserver.patch
>
>
> Over here, we are using parts of the Shindig code base not through servlets but by other means (using RESTlets, to be exact). Some functionality of Shindig is inside the Servlets and this is hard to use if you don't actually have a servlet container to deploy these to.
> The attached patch splits the JsServlet into two parts, JsServlet keeps all the functionality that is servlet specfic and everything else gets moved into JsServer, which contains the Shindig/Javascript specific code. JsServer then gets injected by Guice into the Servlet.
> This patch assumes that SHINDIG-294 and SHINDIG-296 are applied.
> the patch applies to the current trunk directory with "-p2"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-297) Split non-servlet parts of the
JsServlet out
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen updated SHINDIG-297:
-------------------------------------------
Attachment: shindig-297-2.patch
reworked patch. Should apply cleanly with "-p1"
> Split non-servlet parts of the JsServlet out
> --------------------------------------------
>
> Key: SHINDIG-297
> URL: https://issues.apache.org/jira/browse/SHINDIG-297
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Henning Schmiedehausen
> Attachments: jsserver.patch, shindig-297-2.patch
>
>
> Over here, we are using parts of the Shindig code base not through servlets but by other means (using RESTlets, to be exact). Some functionality of Shindig is inside the Servlets and this is hard to use if you don't actually have a servlet container to deploy these to.
> The attached patch splits the JsServlet into two parts, JsServlet keeps all the functionality that is servlet specfic and everything else gets moved into JsServer, which contains the Shindig/Javascript specific code. JsServer then gets injected by Guice into the Servlet.
> This patch assumes that SHINDIG-294 and SHINDIG-296 are applied.
> the patch applies to the current trunk directory with "-p2"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-297) Split non-servlet parts of the
JsServlet out
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598825#action_12598825 ]
Kevin Brown commented on SHINDIG-297:
-------------------------------------
This is a generally useful pattern that I've been applying to the other servlets as well. Servlets are even more annoying because their integration options with Guice is poor. I'm a big fan of moving as much code out of the main servlet and into separate handlers as possible. The style also doesn't really match the rest of the code base.
I also can't apply this one with patch. :)
> Split non-servlet parts of the JsServlet out
> --------------------------------------------
>
> Key: SHINDIG-297
> URL: https://issues.apache.org/jira/browse/SHINDIG-297
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Henning Schmiedehausen
> Attachments: jsserver.patch
>
>
> Over here, we are using parts of the Shindig code base not through servlets but by other means (using RESTlets, to be exact). Some functionality of Shindig is inside the Servlets and this is hard to use if you don't actually have a servlet container to deploy these to.
> The attached patch splits the JsServlet into two parts, JsServlet keeps all the functionality that is servlet specfic and everything else gets moved into JsServer, which contains the Shindig/Javascript specific code. JsServer then gets injected by Guice into the Servlet.
> This patch assumes that SHINDIG-294 and SHINDIG-296 are applied.
> the patch applies to the current trunk directory with "-p2"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-297) Split non-servlet parts of the
JsServlet out
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598852#action_12598852 ]
Henning Schmiedehausen commented on SHINDIG-297:
------------------------------------------------
What patch are you using?
On Linux (Fedora 8):
% svn info .
Path: .
URL: https://svn.apache.org/repos/asf/incubator/shindig/trunk
Repository Root: https://svn.apache.org/repos/asf
Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
Revision: 658928
Node Kind: directory
Schedule: normal
Last Changed Author: lryan
Last Changed Rev: 658918
Last Changed Date: 2008-05-22 01:00:01 +0200 (Thu, 22 May 2008)
% patch -p2 -s < /tmp/jsserver.patch
% svn status
? java/gadgets/src/main/java/org/apache/shindig/gadgets/JsServer.java
M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsServlet.java
M java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
Don't understand why this does not work for you. :-(
> Split non-servlet parts of the JsServlet out
> --------------------------------------------
>
> Key: SHINDIG-297
> URL: https://issues.apache.org/jira/browse/SHINDIG-297
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Henning Schmiedehausen
> Attachments: jsserver.patch
>
>
> Over here, we are using parts of the Shindig code base not through servlets but by other means (using RESTlets, to be exact). Some functionality of Shindig is inside the Servlets and this is hard to use if you don't actually have a servlet container to deploy these to.
> The attached patch splits the JsServlet into two parts, JsServlet keeps all the functionality that is servlet specfic and everything else gets moved into JsServer, which contains the Shindig/Javascript specific code. JsServer then gets injected by Guice into the Servlet.
> This patch assumes that SHINDIG-294 and SHINDIG-296 are applied.
> the patch applies to the current trunk directory with "-p2"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-297) Split non-servlet parts of the
JsServlet out
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598984#action_12598984 ]
Henning Schmiedehausen commented on SHINDIG-297:
------------------------------------------------
I reworked the patch a bit (removed the final qualifiers) and reformatted the source with eclipse formatter (Sun Style + indent size == 2).
If there more than just the Wiki page about style, how about creating one with eclipse and putting it on the wiki for download.
To be blunt, while most Apache projects have a given code style and some even have a "style police", rejecting patches because they are not 100% compliant with a vague description is a bit unusual to me.
> Split non-servlet parts of the JsServlet out
> --------------------------------------------
>
> Key: SHINDIG-297
> URL: https://issues.apache.org/jira/browse/SHINDIG-297
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Henning Schmiedehausen
> Attachments: jsserver.patch, shindig-297-2.patch
>
>
> Over here, we are using parts of the Shindig code base not through servlets but by other means (using RESTlets, to be exact). Some functionality of Shindig is inside the Servlets and this is hard to use if you don't actually have a servlet container to deploy these to.
> The attached patch splits the JsServlet into two parts, JsServlet keeps all the functionality that is servlet specfic and everything else gets moved into JsServer, which contains the Shindig/Javascript specific code. JsServer then gets injected by Guice into the Servlet.
> This patch assumes that SHINDIG-294 and SHINDIG-296 are applied.
> the patch applies to the current trunk directory with "-p2"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.