You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/13 19:38:30 UTC

[GitHub] [beam] robertwb commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

robertwb commented on a change in pull request #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner
URL: https://github.com/apache/beam/pull/11270#discussion_r407673895
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
 ##########
 @@ -914,14 +898,16 @@ def process_bundle(self,
                      expected_outputs,  # type: DataOutput
                      fired_timers,  # type: Mapping[Tuple[str, str], PartitionableBuffer]
                      expected_output_timers  # type: Dict[str, Dict[str, str]]
+                     dry_run=False
 
 Review comment:
   This should be the default, we shouldn't have to pass it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services