You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2017/03/08 02:05:19 UTC
Review Request 57405: HIVE-16104 LLAP: preemption may be too
aggressive if the pre-empted task doesn't die immediately
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57405/
-----------------------------------------------------------
Review request for hive and Siddharth Seth.
Repository: hive-git
Description
-------
see jira
Diffs
-----
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java c1f6c96
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestTaskExecutorService.java bf7d1d8
Diff: https://reviews.apache.org/r/57405/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 57405: HIVE-16104 LLAP: preemption may be too
aggressive if the pre-empted task doesn't die immediately
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57405/
-----------------------------------------------------------
(Updated March 13, 2017, 9:23 p.m.)
Review request for hive and Siddharth Seth.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
llap-server/pom.xml fc392fb
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 2a69d6a
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java c1f6c96
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java 18f0db9
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java 259e383
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestTaskExecutorService.java bf7d1d8
Diff: https://reviews.apache.org/r/57405/diff/7/
Changes: https://reviews.apache.org/r/57405/diff/6-7/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 57405: HIVE-16104 LLAP: preemption may be too
aggressive if the pre-empted task doesn't die immediately
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57405/
-----------------------------------------------------------
(Updated March 10, 2017, 11:19 p.m.)
Review request for hive and Siddharth Seth.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 2a69d6a
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java c1f6c96
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java 18f0db9
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java 259e383
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestTaskExecutorService.java bf7d1d8
Diff: https://reviews.apache.org/r/57405/diff/6/
Changes: https://reviews.apache.org/r/57405/diff/5-6/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 57405: HIVE-16104 LLAP: preemption may be too
aggressive if the pre-empted task doesn't die immediately
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57405/
-----------------------------------------------------------
(Updated March 10, 2017, 8:54 p.m.)
Review request for hive and Siddharth Seth.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java c1f6c96
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java 18f0db9
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestTaskExecutorService.java bf7d1d8
Diff: https://reviews.apache.org/r/57405/diff/5/
Changes: https://reviews.apache.org/r/57405/diff/4-5/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 57405: HIVE-16104 LLAP: preemption may be too
aggressive if the pre-empted task doesn't die immediately
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57405/#review168563
-----------------------------------------------------------
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java
Line 91 (original), 91 (patched)
<https://reviews.apache.org/r/57405/#comment240807>
should be changed to 500, will change in the jira patch, and next revision here if any
- Sergey Shelukhin
On March 10, 2017, 12:20 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57405/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 12:20 a.m.)
>
>
> Review request for hive and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java c1f6c96
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java 18f0db9
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestTaskExecutorService.java bf7d1d8
>
>
> Diff: https://reviews.apache.org/r/57405/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 57405: HIVE-16104 LLAP: preemption may be too
aggressive if the pre-empted task doesn't die immediately
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57405/
-----------------------------------------------------------
(Updated March 10, 2017, 12:20 a.m.)
Review request for hive and Siddharth Seth.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java c1f6c96
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java 18f0db9
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestTaskExecutorService.java bf7d1d8
Diff: https://reviews.apache.org/r/57405/diff/4/
Changes: https://reviews.apache.org/r/57405/diff/3-4/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 57405: HIVE-16104 LLAP: preemption may be too
aggressive if the pre-empted task doesn't die immediately
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57405/
-----------------------------------------------------------
(Updated March 9, 2017, 12:11 a.m.)
Review request for hive and Siddharth Seth.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java c1f6c96
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestTaskExecutorService.java bf7d1d8
Diff: https://reviews.apache.org/r/57405/diff/3/
Changes: https://reviews.apache.org/r/57405/diff/2-3/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 57405: HIVE-16104 LLAP: preemption may be too
aggressive if the pre-empted task doesn't die immediately
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57405/
-----------------------------------------------------------
(Updated March 9, 2017, 12:08 a.m.)
Review request for hive and Siddharth Seth.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java c1f6c96
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestTaskExecutorService.java bf7d1d8
Diff: https://reviews.apache.org/r/57405/diff/2/
Changes: https://reviews.apache.org/r/57405/diff/1-2/
Testing
-------
Thanks,
Sergey Shelukhin