You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by KurtYoung <gi...@git.apache.org> on 2017/02/07 06:19:37 UTC

[GitHub] flink pull request #3281: [FLINK-5727] [table] Unify some API of batch and s...

GitHub user KurtYoung opened a pull request:

    https://github.com/apache/flink/pull/3281

    [FLINK-5727] [table] Unify some API of batch and stream TableEnvironment

    This PR contains 3 changes:
    
    1. move `sql` to base class
    2. unify `scan` and `ingest` to `scan`, and move to base class
    3. move `registerTableSource` to base class and change the parameter type from specific `BatchTableSource` or `StreamTableSource` to their base class: `TableSource`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KurtYoung/flink flink-5727

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3281
    
----
commit 8303b0c1c6320713daf212c6da4d72499c459e42
Author: Kurt Young <yk...@gmail.com>
Date:   2017-02-07T06:15:02Z

    [FLINK-5727] [table] Unify some API of batch and stream TableEnvironment

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3281: [FLINK-5727] [table] Unify some API of batch and stream T...

Posted by KurtYoung <gi...@git.apache.org>.
Github user KurtYoung commented on the issue:

    https://github.com/apache/flink/pull/3281
  
    Hi @fhueske , thanks for your reviewing and comments, it makes sense to me. The motivation behind this refactoring is we want to eliminate most differences between batch and stream execution environment, and use `TableEnvironment` only when they writing programs. 
    
    How about we still keep `registerTableSource` in `TableEnvironment` and leave the implementation to the specific env, and do some type validation before registration. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3281: [FLINK-5727] [table] Unify some API of batch and stream T...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3281
  
    Thanks for the update @KurtYoung.
    
    +1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3281: [FLINK-5727] [table] Unify some API of batch and stream T...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3281
  
    merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3281: [FLINK-5727] [table] Unify some API of batch and s...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3281


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3281: [FLINK-5727] [table] Unify some API of batch and stream T...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3281
  
    Hi @KurtYoung,
    
    thanks for the refactoring. Moving `sql()` and `scan()` to `TableEnvironment` makes sense. 
    
    However, I'd like to keep `registerTableSource` at the `BatchTableEnvironment` and `StreamTableEnvironment` because this separation ensures that a `BatchTableSource` is not registered at a `StreamTableEnvironment` and vice versa. 
    
    What do you think?
    
    Best, Fabian


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---