You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/10/22 02:37:47 UTC
[PR] ci(storybook): use every core for story tests and install deps for Chromium only [superset]
rusackas opened a new pull request, #45600:
URL: https://github.com/apache/superset/pull/45600
### SUMMARY
Two small things in the `test-storybook` job, which is the longest job in the Frontend workflow at about 6.5 minutes:
- The story smoke tests run through Playwright with no `workers` setting, so they get Playwright's default of half the cores: 272 stories on 2 workers took 5.3 minutes on the 4-core runner. The config now uses every core when `CI` is set and keeps the default locally.
- Before the tests, `npx playwright install-deps` spent about 67 seconds installing OS packages for all three browsers (the Chromium download itself is 10 seconds). `npx playwright install --with-deps chromium` installs only Chromium's packages.
The CI run on this PR is the measurement; I'd expect the job to drop by roughly 2 to 3 minutes. If 4 workers turn out flaky on the shared runner we can pin a number instead of `'100%'`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TESTING INSTRUCTIONS
Compare the `test-storybook` job duration on this PR against a recent master run (around 6m30s). Locally, `npm run test-storybook` behaves as before since `CI` isn't set.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(storybook): use every core for story tests and install deps for Chromium only [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #45600:
URL: https://github.com/apache/superset/pull/45600#issuecomment-6331763586
Numbers from the run on 2004e32, against the two master runs of `test-storybook` from the same few hours (6m35s and 6m54s):
| | master | this PR |
|---|---|---|
| playwright install step | 76 s | 26 s |
| story tests (272 stories) | 5.3 min on 2 workers | 3.7 min on 4 workers |
| `test-storybook` job | 6m35s / 6m54s | 5m02s |
The first run on this PR only got the install half, since `docker run` doesn't forward `CI` into the container and the worker setting keys off it; 2004e32 passes it through. Not seeing any flakiness at 4 workers so far, but holler if it shows up and we'll pin a lower number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(storybook): use every core for story tests and install deps for Chromium only [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45600:
URL: https://github.com/apache/superset/pull/45600#issuecomment-6335655127
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45600?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 84.10%. Comparing base ([`4e5d0ef`](https://app.codecov.io/gh/apache/superset/commit/4e5d0ef8f13d1b878801851e1801f9672ef155e4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2004e32`](https://app.codecov.io/gh/apache/superset/commit/2004e3265f9afa21d5c0cd4418c7952500c8aae1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #45600 +/- ##
==========================================
- Coverage 84.10% 84.10% -0.01%
==========================================
Files 3056 3056
Lines 201285 201286 +1
Branches 47066 47066
==========================================
- Hits 169299 169296 -3
- Misses 28747 28751 +4
Partials 3239 3239
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/45600/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/45600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.16% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45600?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(storybook): use every core for story tests and install deps for Chromium only [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #45600:
URL: https://github.com/apache/superset/pull/45600#issuecomment-6331452756
## CodeAnt PR Risk: Low Risk
- The PR appears safe to merge; no actionable issues were identified in the review.
**Assessed commit:** `f5d3c99edc0d`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci(storybook): use every core for story tests and install deps for Chromium only [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #45600:
URL: https://github.com/apache/superset/pull/45600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org