You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/20 19:06:52 UTC

[GitHub] [tvm] alanmacd opened a new pull request, #12851: [microTVM] initial version building TVM on windows with USE_MICRO enabled

alanmacd opened a new pull request, #12851:
URL: https://github.com/apache/tvm/pull/12851

   initial version building TVM on windows with USE_MICRO enabled


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mkatanbaf commented on a diff in pull request #12851: [microTVM][Windows] Enable building TVM on Windows with USE_MICRO

Posted by GitBox <gi...@apache.org>.
mkatanbaf commented on code in PR #12851:
URL: https://github.com/apache/tvm/pull/12851#discussion_r978974099


##########
include/tvm/runtime/crt/rpc_common/write_stream.h:
##########
@@ -29,6 +29,7 @@
 #include <stddef.h>
 #include <sys/types.h>
 #include <tvm/runtime/crt/error_codes.h>
+#include <tvm/support/ssize.h>

Review Comment:
   Thank you @alanmacd! LGTM, I can't think of any reason why this would be a problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mehrdadh commented on a diff in pull request #12851: [microTVM][Windows] Enable building TVM on Windows with USE_MICRO

Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #12851:
URL: https://github.com/apache/tvm/pull/12851#discussion_r993769531


##########
cmake/modules/StandaloneCrt.cmake:
##########
@@ -149,4 +173,6 @@ if(USE_MICRO)
   list(APPEND TVM_RUNTIME_LINKER_LIBS ${TVM_CRT_LINKER_LIB})
   endif()
 
-endif(USE_MICRO)
+endif()
+
+endif()

Review Comment:
   add new line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] alanmacd commented on a diff in pull request #12851: [microTVM][Windows] Enable building TVM on Windows with USE_MICRO

Posted by GitBox <gi...@apache.org>.
alanmacd commented on code in PR #12851:
URL: https://github.com/apache/tvm/pull/12851#discussion_r993780406


##########
cmake/modules/StandaloneCrt.cmake:
##########
@@ -149,4 +173,6 @@ if(USE_MICRO)
   list(APPEND TVM_RUNTIME_LINKER_LIBS ${TVM_CRT_LINKER_LIB})
   endif()
 
-endif(USE_MICRO)
+endif()
+
+endif()

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] alanmacd commented on a diff in pull request #12851: [microTVM][Windows] Enable building TVM on Windows with USE_MICRO

Posted by GitBox <gi...@apache.org>.
alanmacd commented on code in PR #12851:
URL: https://github.com/apache/tvm/pull/12851#discussion_r978078873


##########
include/tvm/runtime/crt/rpc_common/write_stream.h:
##########
@@ -29,6 +29,7 @@
 #include <stddef.h>
 #include <sys/types.h>
 #include <tvm/runtime/crt/error_codes.h>
+#include <tvm/support/ssize.h>

Review Comment:
   @mkatanbaf @areusch I moved ssize.h to this location as otherwise it gets more complicated to include it in other header files, especially across different build flavors (linux, windows, etc.), let me know what you think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] alanmacd commented on pull request #12851: [microTVM] initial version building TVM on windows with USE_MICRO enabled

Posted by GitBox <gi...@apache.org>.
alanmacd commented on PR #12851:
URL: https://github.com/apache/tvm/pull/12851#issuecomment-1255298527

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #12851: [microTVM][Windows] Enable building TVM on Windows with USE_MICRO

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #12851:
URL: https://github.com/apache/tvm/pull/12851#issuecomment-1275538210

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-docs-start-->
    * Built docs for commit 11bafafd4e7422ec7c9327bbb44a751f04ddfc95 can be found [here](https://pr-docs.tlcpack.ai/PR-12851/11/docs/index.html).<!--bot-comment-docs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mehrdadh merged pull request #12851: [microTVM][Windows] Enable building TVM on Windows with USE_MICRO

Posted by GitBox <gi...@apache.org>.
mehrdadh merged PR #12851:
URL: https://github.com/apache/tvm/pull/12851


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mkatanbaf commented on a diff in pull request #12851: [microTVM][Windows] Enable building TVM on Windows with USE_MICRO

Posted by GitBox <gi...@apache.org>.
mkatanbaf commented on code in PR #12851:
URL: https://github.com/apache/tvm/pull/12851#discussion_r978974099


##########
include/tvm/runtime/crt/rpc_common/write_stream.h:
##########
@@ -29,6 +29,7 @@
 #include <stddef.h>
 #include <sys/types.h>
 #include <tvm/runtime/crt/error_codes.h>
+#include <tvm/support/ssize.h>

Review Comment:
   Thank you @alanmacd! LGTM, I can't think of any reason against moving the file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org