You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/02 05:45:32 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #10095: Add typing coverage to mysql providers package

potiuk commented on a change in pull request #10095:
URL: https://github.com/apache/airflow/pull/10095#discussion_r464035103



##########
File path: airflow/providers/mysql/hooks/mysql.py
##########
@@ -182,7 +184,7 @@ def bulk_dump(self, table, tmp_file):
         conn.commit()
 
     @staticmethod
-    def _serialize_cell(cell, conn):  # pylint: disable=signature-differs
+    def _serialize_cell(cell: object, conn: Connection) -> object:  # pylint: disable=signature-differs

Review comment:
       Maybe we can also match the signatures. I believe the "signature-differs" pylint exception can be removed by adding = None for conn parameter. Which is no harm at all.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org