You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/17 09:32:54 UTC

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #920: fix: export apisix type for encoding/json package

tokers commented on a change in pull request #920:
URL: https://github.com/apache/apisix-ingress-controller/pull/920#discussion_r828919978



##########
File path: pkg/kube/apisix_route.go
##########
@@ -54,21 +54,21 @@ type ApisixRouteInformer interface {
 // ApisixRoute is an encapsulation for ApisixRoute resource with different
 // versions, for now, they are apisix.apache.org/v1 and apisix.apache.org/v2alpha1
 type ApisixRoute interface {
-	// GroupVersion returns the api group version of the
+	// GetGroupVersion returns the api group version of the

Review comment:
       Frankly, these changes are trivial and useless, I suggest reverting them back, or it'll also pollute the result of git blame.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org