[GitHub] [doris] zhangstar333 commented on a diff in pull request #19071: [fix](memleak) add destructor for AggregateFunctionHLLData

["zhangstar333 (via GitHub)" <gi...@apache.org>]

zhangstar333 commented on code in PR #19071:
URL: https://github.com/apache/doris/pull/19071#discussion_r1177287923


##########
be/src/vec/aggregate_functions/aggregate_function_hll_union_agg.h:
##########
@@ -51,6 +51,9 @@ namespace doris::vectorized {
 struct AggregateFunctionHLLData {
     HyperLogLog dst_hll {};
 
+    AggregateFunctionHLLData() = default;
+    ~AggregateFunctionHLLData() = default;

Review Comment:
   In my opinion，this is seems generated by the compiler automatically？
   Where does this memory leak come from



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org