You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2015/11/03 23:53:22 UTC

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/
-----------------------------------------------------------

(Updated Nov. 3, 2015, 10:53 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
-------

Rebased and registered added stout tests.


Bugs: MESOS-3551
    https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description (updated)
-------

Also register test cases for stout's strerror; the Makefile for that is
owned by libprocess.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am 53e83d4905945593e174601a0b791d01824dc34b 
  3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
  3rdparty/libprocess/src/poll_socket.cpp 85cd864ebddd72316991a8f2782d3c7c9eebcc54 
  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
  3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
  3rdparty/libprocess/src/subprocess.cpp 459825c188d56d25f6e2832e5a170d806e257d6b 

Diff: https://reviews.apache.org/r/39007/diff/


Testing
-------

make check


Thanks,

Benjamin Bannier

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/#review106233
-----------------------------------------------------------

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 3, 2015, 2:53 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39007/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 2:53 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also register test cases for stout's strerror; the Makefile for that is
> owned by libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 53e83d4905945593e174601a0b791d01824dc34b 
>   3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
>   3rdparty/libprocess/src/poll_socket.cpp 85cd864ebddd72316991a8f2782d3c7c9eebcc54 
>   3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
>   3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
>   3rdparty/libprocess/src/subprocess.cpp 459825c188d56d25f6e2832e5a170d806e257d6b 
> 
> Diff: https://reviews.apache.org/r/39007/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/#review106444
-----------------------------------------------------------

Ship it!


Looks good, we won't need the os/strerror.hpp includes where we already have os.hpp includes anymore. I also made some minor line wrapping changes.

- Ben Mahler


On Nov. 12, 2015, 3:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39007/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 3:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also register test cases for stout's strerror; the Makefile for that is
> owned by libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am b73196cfa18e0d270e2533fbf733ad91e0559286 
>   3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
>   3rdparty/libprocess/src/poll_socket.cpp 85cd864ebddd72316991a8f2782d3c7c9eebcc54 
>   3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
>   3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
>   3rdparty/libprocess/src/subprocess.cpp efe0018d0414c4137fd833c153eb262232e712bc 
> 
> Diff: https://reviews.apache.org/r/39007/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/#review106256
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39005, 39007]

All tests passed.

- Mesos ReviewBot


On Nov. 12, 2015, 3:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39007/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 3:27 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also register test cases for stout's strerror; the Makefile for that is
> owned by libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am b73196cfa18e0d270e2533fbf733ad91e0559286 
>   3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
>   3rdparty/libprocess/src/poll_socket.cpp 85cd864ebddd72316991a8f2782d3c7c9eebcc54 
>   3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
>   3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
>   3rdparty/libprocess/src/subprocess.cpp efe0018d0414c4137fd833c153eb262232e712bc 
> 
> Diff: https://reviews.apache.org/r/39007/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/
-----------------------------------------------------------

(Updated Nov. 12, 2015, 3:27 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
-------

Rebased.


Bugs: MESOS-3551
    https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
-------

Also register test cases for stout's strerror; the Makefile for that is
owned by libprocess.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am b73196cfa18e0d270e2533fbf733ad91e0559286 
  3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
  3rdparty/libprocess/src/poll_socket.cpp 85cd864ebddd72316991a8f2782d3c7c9eebcc54 
  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
  3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
  3rdparty/libprocess/src/subprocess.cpp efe0018d0414c4137fd833c153eb262232e712bc 

Diff: https://reviews.apache.org/r/39007/diff/


Testing
-------

make check


Thanks,

Benjamin Bannier

Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/#review105017
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39005, 39006, 39007]

All tests passed.

- Mesos ReviewBot


On Nov. 3, 2015, 10:53 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39007/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 10:53 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also register test cases for stout's strerror; the Makefile for that is
> owned by libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 53e83d4905945593e174601a0b791d01824dc34b 
>   3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
>   3rdparty/libprocess/src/poll_socket.cpp 85cd864ebddd72316991a8f2782d3c7c9eebcc54 
>   3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
>   3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
>   3rdparty/libprocess/src/subprocess.cpp 459825c188d56d25f6e2832e5a170d806e257d6b 
> 
> Diff: https://reviews.apache.org/r/39007/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>