You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2025/10/07 22:54:16 UTC
[PR] chore: avoid build warning [opendal]
tisonkun opened a new pull request, #6627:
URL: https://github.com/apache/opendal/pull/6627
cc @erickguan for verification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: avoid build warning [opendal]
Posted by "erickguan (via GitHub)" <gi...@apache.org>.
erickguan commented on code in PR #6627:
URL: https://github.com/apache/opendal/pull/6627#discussion_r2412714216
##########
bindings/ruby/Cargo.toml:
##########
@@ -36,7 +36,7 @@ name = "opendal_ruby"
magnus = { version = "0.8", features = ["bytes", "io"] }
# 1. this crate won't be published, we always use the local version
# 2. we use the symbolink to allow released gem to find core's source files.
-opendal = { version = ">=0", path = "./core", features = [
+opendal = { version = ">=0", path = "../../core", features = [
Review Comment:
The problem is that distributed gem can't look into the parent directory for security reasons.
@tisonkun do you have a way to resolve this based on dev/distributed environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: avoid build warning [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #6627:
URL: https://github.com/apache/opendal/pull/6627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: avoid build warning [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #6627:
URL: https://github.com/apache/opendal/pull/6627#discussion_r2412112378
##########
bindings/ruby/Rakefile:
##########
@@ -93,27 +93,14 @@ task :version do
print GEMSPEC.version
end
-desc "Resolve symlinks in core directory for gem packaging" # Read more in `.release-ruby.yml`
-task :resolve_symlinks do
- puts "Changing symlinks in core directory to actual files for packaging..."
- Dir.chdir("core") do # a symbolic link to OpenDAL core for packaging
- Dir.glob("**/*", File::FNM_DOTMATCH).each do |file|
- next unless File.symlink?(file)
-
- link_target = File.readlink(file)
- resolved_path = File.expand_path(link_target, File.dirname(file))
-
- if File.exist?(resolved_path)
- puts "Resolving symlink: #{file} -> #{link_target}"
- File.delete(file)
- FileUtils.cp(resolved_path, file)
- end
- end
- end
+desc "Copy the core directory for gem packaging" # Read more in `./.github/workflows/release-ruby.yml`
+task :copy_core do
+ puts "Copy the core directory for packaging..."
+ FileUtils.cp_r('../../core', '.')
Review Comment:
Perhaps add to `.gitigonre` and delete every time before copy. But let's first verify a happy path can work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: avoid build warning [opendal]
Posted by "erickguan (via GitHub)" <gi...@apache.org>.
erickguan commented on code in PR #6627:
URL: https://github.com/apache/opendal/pull/6627#discussion_r2412714216
##########
bindings/ruby/Cargo.toml:
##########
@@ -36,7 +36,7 @@ name = "opendal_ruby"
magnus = { version = "0.8", features = ["bytes", "io"] }
# 1. this crate won't be published, we always use the local version
# 2. we use the symbolink to allow released gem to find core's source files.
-opendal = { version = ">=0", path = "./core", features = [
+opendal = { version = ">=0", path = "../../core", features = [
Review Comment:
The problem is that distributed gem can't look into parent directory for security reasons.
@tisonkun do you have a way to resolve this based on dev/distributed environment?
##########
.github/workflows/release_ruby.yml:
##########
@@ -20,7 +20,9 @@ name: Release Ruby Binding
on:
push:
tags:
- - 'v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+' # Triggers on version tags (v0.54.0, v0.54.0-rc.1, etc.)
+ # Triggers on version tags (v0.54.0, v0.54.0-rc.1, etc.)
+ - 'v[0-9]+.[0-9]+.[0-9]+'
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: avoid build warning [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #6627:
URL: https://github.com/apache/opendal/pull/6627#issuecomment-3379124442
`opendal.gemspec` has symbol link resolving logics also.
@erikguan could you please take a look? Anyway we should avoid simply adding a symbol link to `core` from `bindings/ruby` which may cause Cargo hazard.
Not quite sure if gem only include files in the same directory and we should do something different. For example, always copy `core` to `bindings/ruby` before any command, but exclude it from the cargo packaged source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: avoid build warning [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #6627:
URL: https://github.com/apache/opendal/pull/6627#issuecomment-3379722613
I'll merge this patch first. And @erickguan can give another look for further improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org