[GitHub] sidSingla commented on a change in pull request #3329: Syncing the timeout param from backend

[gi...@git.apache.org]

sidSingla commented on a change in pull request #3329: Syncing the timeout param from backend
URL: https://github.com/apache/incubator-superset/pull/3329#discussion_r140771765
 
 

 ##########
 File path: superset/assets/javascripts/SqlLab/components/VisualizeModal.jsx
 ##########
 @@ -133,12 +133,13 @@ class VisualizeModal extends React.PureComponent {
   }
   buildVisualizeAdvise() {
     let advise;
+    const timeout = this.props.timeout;
     const queryDuration = moment.duration(this.props.query.endDttm - this.props.query.startDttm);
-    if (Math.round(queryDuration.asMilliseconds()) > QUERY_TIMEOUT_THRESHOLD) {
 
 Review comment:
   Can anyone tell which is the new constant supplanting QUERY_TIMEOUT_THRESHOLD.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services