You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cfries <gi...@git.apache.org> on 2017/04/21 17:18:30 UTC
[GitHub] zeppelin pull request #2276: [ZEPPELIN-2410]: Using UUID from filename in re...
GitHub user cfries opened a pull request:
https://github.com/apache/zeppelin/pull/2276
[ZEPPELIN-2410]: Using UUID from filename in registry cache dir inste\u2026
\u2026ad of uri.
The previous version of this file used the full uri as file name in the
cache. This included special characters like the : in http: which
caused problems.
Since this is just a cache file, a better approach is to use an UUID.
The UUID is constructed from the URI to avoid the cache dir to grow
over time (in case there is no clean up of the cache dir).
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cfries/zeppelin helium-cache-filename-patch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2276.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2276
----
commit 5fda58f29c261b8fd61353a2b09c0f90c19d3fa4
Author: Christian Fries <em...@christian-fries.de>
Date: 2017-04-21T15:07:00Z
[ZEPPELIN-2410]: Using UUID from filename in registry cache dir instead of uri.
The previous version of this file used the full uri as file name in the
cache. This included special characters like the : in http: which
caused problems.
Since this is just a cache file, a better approach is to use an UUID.
The UUID is constructed from the URI to avoid the cache dir to grow
over time (in case there is no clean up of the cache dir).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2276: [ZEPPELIN-2410]: Using UUID from filename in registry ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2276
Merge to master and branch-0.7 if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2276: [ZEPPELIN-2410]: Using UUID from filename in re...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2276: [ZEPPELIN-2410]: Using UUID from filename in registry ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2276
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---