You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by SHUANG SU <su...@gmail.com> on 2019/09/05 08:01:06 UTC
[VOTE] Release Apache ECharts (incubating) 4.3.0 (release candidate 1)
I am pleased to be calling this vote for the release of Apache ECharts
(incubating) 4.3.0 (release candidate 1).
Apache ECharts community has voted and approved the release.
Vote thread:
https://lists.apache.org/thread.html/e17e9a8d94c81019b073ef7f5cee9075d6921f01cdd8840f9618b012@%3Cdev.echarts.apache.org%3E
Results thread:
https://lists.apache.org/thread.html/0d52c6ed1e5d1b6bc72b56e1b240063577fde4d9cc3c227d33396caa@%3Cdev.echarts.apache.org%3E
The release candidate to be voted over is available at:
https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.1/
The release candidate is signed with a GPG key available at:
https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS
The Git commit for this release is:
https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=b62ab99
The Release Note is available in:
https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.1/RELEASE_NOTE.txt
Some shell commands for validating the release:
```shell
# Download the release:
curl
https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.1/apache-echarts-4.3.0-rc.1-incubating-src.zip
-o apache-echarts-4.3.0-rc.1-incubating-src.zip
unzip apache-echarts-4.3.0-rc.1-incubating-src.zip -d
apache-echarts-4.3.0-rc.1-incubating-src > /dev/null
# Rebuild the project (Node.js environment is required):
cd "apache-echarts-4.3.0-rc.1-incubating-src" && npm install && cd ..
node "apache-echarts-4.3.0-rc.1-incubating-src/build/build.js" --release
# (See help: `node
"apache-echarts-4.3.0-rc.1-incubating-src/build/build.js" --help`)
```
Please vote on releasing this package as:
Apache ECharts (incubating) 4.3.0 (release candidate 1)
by "2019-09-08T08:57:30.519Z".
[ ] +1 Release this package
[ ] 0 I don't feel strongly about it, but don't object
[ ] -1 Do not release this package because...
Anyone can participate in testing and voting, not just committers, please
feel free to try out the release candidate and provide your votes.
A checklist for reference:
https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
Thanks,
------------------------------
Su Shuang (100pah)
------------------------------
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 1)
Posted by Yi Shen <sh...@gmail.com>.
Hi, thanks for the advice.
We don't recommend using author tag any more. The remaining author tags in
these codes can also be removed.
I'd suggest fixing these issues and start a new release vote.
On Fri, Sep 6, 2019 at 2:36 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > File author is optional for me, if you want to keep it, just keep it, as
> it
> > has ASF header already.
>
> It was long ago decided that @author tags should generally not be used in
> any ASF code. This the main discussion was back in 2004 I think and the
> board recommend that author tags not be used for both legal and community
> reasons. Perhaps someone who been around longer to me can remember the
> discussion / find a link?
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
--
Yi Shen
Senior Developer
Baidu, Inc.
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 1)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Thanks for bringing this up, look forward the discussion and link too.
See for instance see discussion items F in [1]. Legally, I think the discussion was around if your name in there then you could be a target, however if you name is just on the commit, then you are protected by the legal shield the ASF gives.
Thanks,
Justin
1. http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_09_22.txt
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 1)
Posted by Sheng Wu <wu...@gmail.com>.
Justin Mclean <ju...@classsoftware.com> 于2019年9月5日周四 下午11:36写道：
> Hi,
>
> > File author is optional for me, if you want to keep it, just keep it, as
> it
> > has ASF header already.
>
> It was long ago decided that @author tags should generally not be used in
> any ASF code. This the main discussion was back in 2004 I think and the
> board recommend that author tags not be used for both legal and community
> reasons. Perhaps someone who been around longer to me can remember the
> discussion / find a link?
>
Hi
Thanks for bringing this up, look forward the discussion and link too.
Sheng Wu 吴晟
Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
Twitter, wusheng1108
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 1)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> File author is optional for me, if you want to keep it, just keep it, as it
> has ASF header already.
It was long ago decided that @author tags should generally not be used in any ASF code. This the main discussion was back in 2004 I think and the board recommend that author tags not be used for both legal and community reasons. Perhaps someone who been around longer to me can remember the discussion / find a link?
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 1)
Posted by Sheng Wu <wu...@gmail.com>.
Hi Shen Yi
Based on the license issue of source code[5][28], I also commend to run the
release vote after these two fixed.
File author is optional for me, if you want to keep it, just keep it, as it
has ASF header already.
Sheng Wu 吴晟
Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
Twitter, wusheng1108
Yi Shen <sh...@gmail.com> 于2019年9月5日周四 下午10:45写道：
> Hi Justin,
>
> 1. The Stack Overflow link we referenced in file [1] is an explanation of
> why this issue happens. We didn't use the code.
>
> 2. About files with author tags [6] - [24], it's because we used to add
> author names at the beginning of files as a convention.
> There are still some files keep it. They are not third party files
>
> Author of files [6], [7], [8], [21], [22], [24] is me (shenyi@apache.org)
> Author of files [9] - [20] is Deqing Li (deqingli@apache.org)
> Author of file [23] is Xiaohong Deng. She is one of our contributors, but
> not committer.
>
> We will remove the author tags in these files.
>
> 3. I wrote the code of file [28]. It's a parser of GEXF file format.
> The link in this file is broken. It's the specification of this format. The
> new link is https://gephi.org/gexf/1.2draft/gexf-12draft-primer.pdf
>
> 4. We will remove the function related to the code from Stack Overflow in
> file [5] and rewrite the code in file [26] before we start a new vote.
>
> Thanks.
>
> On Fri, Sep 6, 2019 at 7:33 AM Justin Mclean <ju...@classsoftware.com>
> wrote:
>
> > Hi,
> >
> > -1 binding (release includes Category X licensed code)
> >
> > I checked:
> > - signatures and hashes fine
> > - DISCLAIMER exists
> > - LICENSE may have some issues and missing some license information (see
> > below)
> > - NOTICE is fine
> > - all source file have ASF headers
> > - no unexpected binary files
> >
> > This file [1] contain code from [2] this is probably not compatible with
> > the ALv2 [3][4]. Also this file [5].
> >
> > It’s unclear how this file [6] is licensed and it may incorrectly have an
> > ASF header. On closer inspection there see to be a number of files which
> > might be 3rd party and incorrectly have an ASF header. [7] - [24]. You’ll
> > note these files have author tags. Where did these files come from?
> >
> > Some code in here [25] from this blog is licensed CC 4.0 BY_SA, this is
> > not compatible with the Apache license. [27]
> >
> > Do you have permission to use this code [28] from the authors and is it
> in
> > under an Apache license as the file header states?
> >
> > There are also a number of references to http://echarts.baidu.com in the
> > code which should probably change.
> >
> > You might want to consider using the work in progress disclaimer [29] and
> > documenting the issues in that until they are fixed.
> >
> > Thanks,
> > Justin
> >
> > 1. ./src/component/tooltip/TooltipContent.js
> > 2.
> >
> https://stackoverflow.com/questions/21125587/css3-transition-not-working-in-chrome-anymore
> > 3. https://apache.org/legal/resolved.html#stackoverflow
> > 4. https://issues.apache.org/jira/browse/LEGAL-471
> > 5. ./src/component/toolbox/feature/DataView.js
> > 6. ./src/chart/chord/chordCircularLayout.js
> > 7. ./src/util/KDTree.js
> > 8. ./src/util/quickSelect.js
> > 9. ./src/chart/tree/TreeSeries.js
> > 10. ./src/chart/tree/treeAction.js
> > 11. ./src/chart/tree/TreeView.js
> > 12. ./src/chart/sankey/sankeyAction.js
> > 13. ./src/chart/sankey/SankeySeries.js
> > 14. ./src/chart/sankey/sankeyLayout.js
> > 15. ./src/chart/sankey/SankeyView.js
> > 16. ./src/chart/sankey/sankeyVisual.js
> > 17. ./src/chart/themeRiver/themeRiverVisual.js
> > 18. ./src/chart/themeRiver/themeRiverLayout.js
> > 19. ./src/chart/themeRiver/ThemeRiverSeries.js
> > 20. ./src/chart/themeRiver/ThemeRiverView.js
> > 21. ./src/chart/heatmap/HeatmapLayer.js
> > 22, ./src/chart/chord/chordCircularLayout.js
> > 23. ./src/component/calendar.js
> > 24. ./src/data/Graph.js
> > 25. ./src/component/brush/selector.js
> > 26. http://blog.csdn.net/rickliuxiao/article/details/6259322
> > 27. https://apache.org/legal/resolved.html#cc-sa
> > 28. ./extension-src/dataTool/gexf.js
> > 29. https://incubator.apache.org/policy/incubation.html#disclaimers
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
> --
> Yi Shen
> Senior Developer
> Baidu, Inc.
>
回复：Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release candidate 1)
Posted by Liu Ted <te...@yahoo.com.INVALID>.
As Justin said: "You might want to consider using the work in progress disclaimer [29] and documenting the issues in that until they are fixed."
Best regards,
Ted Liu,
ASF Member, Incubator PMC Member
2019 年 9 月 6 日周五 14:10，Justin Mclean<ju...@gmail.com> 写道： Hi,
I did note that somr of those author tags reference external github repos
which seems odd if they are ASF code.
Thanks.
Justin
On Fri, 6 Sep 2019, 16:04 Justin Mclean, <ju...@gmail.com> wrote:
> Hi,
>
> Thanks for the explanation.
>
> My -1 vote is not a veto and other IPMC members may vote +1. You can of
> course decide not to wait and make anther release. Did any of your mentors
> vote on this release?
>
> Re [2] the ASF generally doesn't like author tags, the code belongs to the
> community not an individual.
>
> Re [4] you could just use the work in progress disclaimer and note that
> these are issues to be fixed later. You could also ask the authors for
> permission to use the code under another license and if given not rewrite
> the code.
>
> Thanks,
> Justin
>
>
> On Fri, 6 Sep 2019, 15:45 Yi Shen, <sh...@gmail.com> wrote:
>
>> Hi Justin,
>>
>> 1. The Stack Overflow link we referenced in file [1] is an explanation of
>> why this issue happens. We didn't use the code.
>>
>> 2. About files with author tags [6] - [24], it's because we used to add
>> author names at the beginning of files as a convention.
>> There are still some files keep it. They are not third party files
>>
>> Author of files [6], [7], [8], [21], [22], [24] is me (shenyi@apache.org)
>> Author of files [9] - [20] is Deqing Li (deqingli@apache.org)
>> Author of file [23] is Xiaohong Deng. She is one of our contributors, but
>> not committer.
>>
>> We will remove the author tags in these files.
>>
>> 3. I wrote the code of file [28]. It's a parser of GEXF file format.
>> The link in this file is broken. It's the specification of this format.
>> The
>> new link is https://gephi.org/gexf/1.2draft/gexf-12draft-primer.pdf
>>
>> 4. We will remove the function related to the code from Stack Overflow in
>> file [5] and rewrite the code in file [26] before we start a new vote.
>>
>> Thanks.
>>
>> On Fri, Sep 6, 2019 at 7:33 AM Justin Mclean <ju...@classsoftware.com>
>> wrote:
>>
>> > Hi,
>> >
>> > -1 binding (release includes Category X licensed code)
>> >
>> > I checked:
>> > - signatures and hashes fine
>> > - DISCLAIMER exists
>> > - LICENSE may have some issues and missing some license information (see
>> > below)
>> > - NOTICE is fine
>> > - all source file have ASF headers
>> > - no unexpected binary files
>> >
>> > This file [1] contain code from [2] this is probably not compatible with
>> > the ALv2 [3][4]. Also this file [5].
>> >
>> > It’s unclear how this file [6] is licensed and it may incorrectly have
>> an
>> > ASF header. On closer inspection there see to be a number of files which
>> > might be 3rd party and incorrectly have an ASF header. [7] - [24].
>> You’ll
>> > note these files have author tags. Where did these files come from?
>> >
>> > Some code in here [25] from this blog is licensed CC 4.0 BY_SA, this is
>> > not compatible with the Apache license. [27]
>> >
>> > Do you have permission to use this code [28] from the authors and is it
>> in
>> > under an Apache license as the file header states?
>> >
>> > There are also a number of references to http://echarts.baidu.com in
>> the
>> > code which should probably change.
>> >
>> > You might want to consider using the work in progress disclaimer [29]
>> and
>> > documenting the issues in that until they are fixed.
>> >
>> > Thanks,
>> > Justin
>> >
>> > 1. ./src/component/tooltip/TooltipContent.js
>> > 2.
>> >
>> https://stackoverflow.com/questions/21125587/css3-transition-not-working-in-chrome-anymore
>> > 3. https://apache.org/legal/resolved.html#stackoverflow
>> > 4. https://issues.apache.org/jira/browse/LEGAL-471
>> > 5. ./src/component/toolbox/feature/DataView.js
>> > 6. ./src/chart/chord/chordCircularLayout.js
>> > 7. ./src/util/KDTree.js
>> > 8. ./src/util/quickSelect.js
>> > 9. ./src/chart/tree/TreeSeries.js
>> > 10. ./src/chart/tree/treeAction.js
>> > 11. ./src/chart/tree/TreeView.js
>> > 12. ./src/chart/sankey/sankeyAction.js
>> > 13. ./src/chart/sankey/SankeySeries.js
>> > 14. ./src/chart/sankey/sankeyLayout.js
>> > 15. ./src/chart/sankey/SankeyView.js
>> > 16. ./src/chart/sankey/sankeyVisual.js
>> > 17. ./src/chart/themeRiver/themeRiverVisual.js
>> > 18. ./src/chart/themeRiver/themeRiverLayout.js
>> > 19. ./src/chart/themeRiver/ThemeRiverSeries.js
>> > 20. ./src/chart/themeRiver/ThemeRiverView.js
>> > 21. ./src/chart/heatmap/HeatmapLayer.js
>> > 22, ./src/chart/chord/chordCircularLayout.js
>> > 23. ./src/component/calendar.js
>> > 24. ./src/data/Graph.js
>> > 25. ./src/component/brush/selector.js
>> > 26. http://blog.csdn.net/rickliuxiao/article/details/6259322
>> > 27. https://apache.org/legal/resolved.html#cc-sa
>> > 28. ./extension-src/dataTool/gexf.js
>> > 29. https://incubator.apache.org/policy/incubation.html#disclaimers
>> >
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: general-help@incubator.apache.org
>> >
>> >
>>
>> --
>> Yi Shen
>> Senior Developer
>> Baidu, Inc.
>>
>
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 1)
Posted by Sheng Wu <wu...@gmail.com>.
I would only suggest if we are comfortable with that, use tag only for
release versions.
Otherwise, let's work on the document about the tag usage for clearance.
I believe the tag usage is no strict rule, but many projects are only using
it for release or release rc during voting.
Sheng Wu 吴晟
Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
Twitter, wusheng1108
Justin Mclean <ju...@gmail.com> 于2019年9月5日周四 下午11:10写道：
> Hi,
> I did note that somr of those author tags reference external github repos
> which seems odd if they are ASF code.
> Thanks.
> Justin
>
> On Fri, 6 Sep 2019, 16:04 Justin Mclean, <ju...@gmail.com> wrote:
>
> > Hi,
> >
> > Thanks for the explanation.
> >
> > My -1 vote is not a veto and other IPMC members may vote +1. You can of
> > course decide not to wait and make anther release. Did any of your
> mentors
> > vote on this release?
> >
> > Re [2] the ASF generally doesn't like author tags, the code belongs to
> the
> > community not an individual.
> >
> > Re [4] you could just use the work in progress disclaimer and note that
> > these are issues to be fixed later. You could also ask the authors for
> > permission to use the code under another license and if given not rewrite
> > the code.
> >
> > Thanks,
> > Justin
> >
> >
> > On Fri, 6 Sep 2019, 15:45 Yi Shen, <sh...@gmail.com> wrote:
> >
> >> Hi Justin,
> >>
> >> 1. The Stack Overflow link we referenced in file [1] is an explanation
> of
> >> why this issue happens. We didn't use the code.
> >>
> >> 2. About files with author tags [6] - [24], it's because we used to add
> >> author names at the beginning of files as a convention.
> >> There are still some files keep it. They are not third party files
> >>
> >> Author of files [6], [7], [8], [21], [22], [24] is me (
> shenyi@apache.org)
> >> Author of files [9] - [20] is Deqing Li (deqingli@apache.org)
> >> Author of file [23] is Xiaohong Deng. She is one of our contributors,
> but
> >> not committer.
> >>
> >> We will remove the author tags in these files.
> >>
> >> 3. I wrote the code of file [28]. It's a parser of GEXF file format.
> >> The link in this file is broken. It's the specification of this format.
> >> The
> >> new link is https://gephi.org/gexf/1.2draft/gexf-12draft-primer.pdf
> >>
> >> 4. We will remove the function related to the code from Stack Overflow
> in
> >> file [5] and rewrite the code in file [26] before we start a new vote.
> >>
> >> Thanks.
> >>
> >> On Fri, Sep 6, 2019 at 7:33 AM Justin Mclean <ju...@classsoftware.com>
> >> wrote:
> >>
> >> > Hi,
> >> >
> >> > -1 binding (release includes Category X licensed code)
> >> >
> >> > I checked:
> >> > - signatures and hashes fine
> >> > - DISCLAIMER exists
> >> > - LICENSE may have some issues and missing some license information
> (see
> >> > below)
> >> > - NOTICE is fine
> >> > - all source file have ASF headers
> >> > - no unexpected binary files
> >> >
> >> > This file [1] contain code from [2] this is probably not compatible
> with
> >> > the ALv2 [3][4]. Also this file [5].
> >> >
> >> > It’s unclear how this file [6] is licensed and it may incorrectly have
> >> an
> >> > ASF header. On closer inspection there see to be a number of files
> which
> >> > might be 3rd party and incorrectly have an ASF header. [7] - [24].
> >> You’ll
> >> > note these files have author tags. Where did these files come from?
> >> >
> >> > Some code in here [25] from this blog is licensed CC 4.0 BY_SA, this
> is
> >> > not compatible with the Apache license. [27]
> >> >
> >> > Do you have permission to use this code [28] from the authors and is
> it
> >> in
> >> > under an Apache license as the file header states?
> >> >
> >> > There are also a number of references to http://echarts.baidu.com in
> >> the
> >> > code which should probably change.
> >> >
> >> > You might want to consider using the work in progress disclaimer [29]
> >> and
> >> > documenting the issues in that until they are fixed.
> >> >
> >> > Thanks,
> >> > Justin
> >> >
> >> > 1. ./src/component/tooltip/TooltipContent.js
> >> > 2.
> >> >
> >>
> https://stackoverflow.com/questions/21125587/css3-transition-not-working-in-chrome-anymore
> >> > 3. https://apache.org/legal/resolved.html#stackoverflow
> >> > 4. https://issues.apache.org/jira/browse/LEGAL-471
> >> > 5. ./src/component/toolbox/feature/DataView.js
> >> > 6. ./src/chart/chord/chordCircularLayout.js
> >> > 7. ./src/util/KDTree.js
> >> > 8. ./src/util/quickSelect.js
> >> > 9. ./src/chart/tree/TreeSeries.js
> >> > 10. ./src/chart/tree/treeAction.js
> >> > 11. ./src/chart/tree/TreeView.js
> >> > 12. ./src/chart/sankey/sankeyAction.js
> >> > 13. ./src/chart/sankey/SankeySeries.js
> >> > 14. ./src/chart/sankey/sankeyLayout.js
> >> > 15. ./src/chart/sankey/SankeyView.js
> >> > 16. ./src/chart/sankey/sankeyVisual.js
> >> > 17. ./src/chart/themeRiver/themeRiverVisual.js
> >> > 18. ./src/chart/themeRiver/themeRiverLayout.js
> >> > 19. ./src/chart/themeRiver/ThemeRiverSeries.js
> >> > 20. ./src/chart/themeRiver/ThemeRiverView.js
> >> > 21. ./src/chart/heatmap/HeatmapLayer.js
> >> > 22, ./src/chart/chord/chordCircularLayout.js
> >> > 23. ./src/component/calendar.js
> >> > 24. ./src/data/Graph.js
> >> > 25. ./src/component/brush/selector.js
> >> > 26. http://blog.csdn.net/rickliuxiao/article/details/6259322
> >> > 27. https://apache.org/legal/resolved.html#cc-sa
> >> > 28. ./extension-src/dataTool/gexf.js
> >> > 29. https://incubator.apache.org/policy/incubation.html#disclaimers
> >> >
> >> >
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> > For additional commands, e-mail: general-help@incubator.apache.org
> >> >
> >> >
> >>
> >> --
> >> Yi Shen
> >> Senior Developer
> >> Baidu, Inc.
> >>
> >
>
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 1)
Posted by Justin Mclean <ju...@gmail.com>.
Hi,
I did note that somr of those author tags reference external github repos
which seems odd if they are ASF code.
Thanks.
Justin
On Fri, 6 Sep 2019, 16:04 Justin Mclean, <ju...@gmail.com> wrote:
> Hi,
>
> Thanks for the explanation.
>
> My -1 vote is not a veto and other IPMC members may vote +1. You can of
> course decide not to wait and make anther release. Did any of your mentors
> vote on this release?
>
> Re [2] the ASF generally doesn't like author tags, the code belongs to the
> community not an individual.
>
> Re [4] you could just use the work in progress disclaimer and note that
> these are issues to be fixed later. You could also ask the authors for
> permission to use the code under another license and if given not rewrite
> the code.
>
> Thanks,
> Justin
>
>
> On Fri, 6 Sep 2019, 15:45 Yi Shen, <sh...@gmail.com> wrote:
>
>> Hi Justin,
>>
>> 1. The Stack Overflow link we referenced in file [1] is an explanation of
>> why this issue happens. We didn't use the code.
>>
>> 2. About files with author tags [6] - [24], it's because we used to add
>> author names at the beginning of files as a convention.
>> There are still some files keep it. They are not third party files
>>
>> Author of files [6], [7], [8], [21], [22], [24] is me (shenyi@apache.org)
>> Author of files [9] - [20] is Deqing Li (deqingli@apache.org)
>> Author of file [23] is Xiaohong Deng. She is one of our contributors, but
>> not committer.
>>
>> We will remove the author tags in these files.
>>
>> 3. I wrote the code of file [28]. It's a parser of GEXF file format.
>> The link in this file is broken. It's the specification of this format.
>> The
>> new link is https://gephi.org/gexf/1.2draft/gexf-12draft-primer.pdf
>>
>> 4. We will remove the function related to the code from Stack Overflow in
>> file [5] and rewrite the code in file [26] before we start a new vote.
>>
>> Thanks.
>>
>> On Fri, Sep 6, 2019 at 7:33 AM Justin Mclean <ju...@classsoftware.com>
>> wrote:
>>
>> > Hi,
>> >
>> > -1 binding (release includes Category X licensed code)
>> >
>> > I checked:
>> > - signatures and hashes fine
>> > - DISCLAIMER exists
>> > - LICENSE may have some issues and missing some license information (see
>> > below)
>> > - NOTICE is fine
>> > - all source file have ASF headers
>> > - no unexpected binary files
>> >
>> > This file [1] contain code from [2] this is probably not compatible with
>> > the ALv2 [3][4]. Also this file [5].
>> >
>> > It’s unclear how this file [6] is licensed and it may incorrectly have
>> an
>> > ASF header. On closer inspection there see to be a number of files which
>> > might be 3rd party and incorrectly have an ASF header. [7] - [24].
>> You’ll
>> > note these files have author tags. Where did these files come from?
>> >
>> > Some code in here [25] from this blog is licensed CC 4.0 BY_SA, this is
>> > not compatible with the Apache license. [27]
>> >
>> > Do you have permission to use this code [28] from the authors and is it
>> in
>> > under an Apache license as the file header states?
>> >
>> > There are also a number of references to http://echarts.baidu.com in
>> the
>> > code which should probably change.
>> >
>> > You might want to consider using the work in progress disclaimer [29]
>> and
>> > documenting the issues in that until they are fixed.
>> >
>> > Thanks,
>> > Justin
>> >
>> > 1. ./src/component/tooltip/TooltipContent.js
>> > 2.
>> >
>> https://stackoverflow.com/questions/21125587/css3-transition-not-working-in-chrome-anymore
>> > 3. https://apache.org/legal/resolved.html#stackoverflow
>> > 4. https://issues.apache.org/jira/browse/LEGAL-471
>> > 5. ./src/component/toolbox/feature/DataView.js
>> > 6. ./src/chart/chord/chordCircularLayout.js
>> > 7. ./src/util/KDTree.js
>> > 8. ./src/util/quickSelect.js
>> > 9. ./src/chart/tree/TreeSeries.js
>> > 10. ./src/chart/tree/treeAction.js
>> > 11. ./src/chart/tree/TreeView.js
>> > 12. ./src/chart/sankey/sankeyAction.js
>> > 13. ./src/chart/sankey/SankeySeries.js
>> > 14. ./src/chart/sankey/sankeyLayout.js
>> > 15. ./src/chart/sankey/SankeyView.js
>> > 16. ./src/chart/sankey/sankeyVisual.js
>> > 17. ./src/chart/themeRiver/themeRiverVisual.js
>> > 18. ./src/chart/themeRiver/themeRiverLayout.js
>> > 19. ./src/chart/themeRiver/ThemeRiverSeries.js
>> > 20. ./src/chart/themeRiver/ThemeRiverView.js
>> > 21. ./src/chart/heatmap/HeatmapLayer.js
>> > 22, ./src/chart/chord/chordCircularLayout.js
>> > 23. ./src/component/calendar.js
>> > 24. ./src/data/Graph.js
>> > 25. ./src/component/brush/selector.js
>> > 26. http://blog.csdn.net/rickliuxiao/article/details/6259322
>> > 27. https://apache.org/legal/resolved.html#cc-sa
>> > 28. ./extension-src/dataTool/gexf.js
>> > 29. https://incubator.apache.org/policy/incubation.html#disclaimers
>> >
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: general-help@incubator.apache.org
>> >
>> >
>>
>> --
>> Yi Shen
>> Senior Developer
>> Baidu, Inc.
>>
>
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 1)
Posted by Justin Mclean <ju...@gmail.com>.
Hi,
Thanks for the explanation.
My -1 vote is not a veto and other IPMC members may vote +1. You can of
course decide not to wait and make anther release. Did any of your mentors
vote on this release?
Re [2] the ASF generally doesn't like author tags, the code belongs to the
community not an individual.
Re [4] you could just use the work in progress disclaimer and note that
these are issues to be fixed later. You could also ask the authors for
permission to use the code under another license and if given not rewrite
the code.
Thanks,
Justin
On Fri, 6 Sep 2019, 15:45 Yi Shen, <sh...@gmail.com> wrote:
> Hi Justin,
>
> 1. The Stack Overflow link we referenced in file [1] is an explanation of
> why this issue happens. We didn't use the code.
>
> 2. About files with author tags [6] - [24], it's because we used to add
> author names at the beginning of files as a convention.
> There are still some files keep it. They are not third party files
>
> Author of files [6], [7], [8], [21], [22], [24] is me (shenyi@apache.org)
> Author of files [9] - [20] is Deqing Li (deqingli@apache.org)
> Author of file [23] is Xiaohong Deng. She is one of our contributors, but
> not committer.
>
> We will remove the author tags in these files.
>
> 3. I wrote the code of file [28]. It's a parser of GEXF file format.
> The link in this file is broken. It's the specification of this format. The
> new link is https://gephi.org/gexf/1.2draft/gexf-12draft-primer.pdf
>
> 4. We will remove the function related to the code from Stack Overflow in
> file [5] and rewrite the code in file [26] before we start a new vote.
>
> Thanks.
>
> On Fri, Sep 6, 2019 at 7:33 AM Justin Mclean <ju...@classsoftware.com>
> wrote:
>
> > Hi,
> >
> > -1 binding (release includes Category X licensed code)
> >
> > I checked:
> > - signatures and hashes fine
> > - DISCLAIMER exists
> > - LICENSE may have some issues and missing some license information (see
> > below)
> > - NOTICE is fine
> > - all source file have ASF headers
> > - no unexpected binary files
> >
> > This file [1] contain code from [2] this is probably not compatible with
> > the ALv2 [3][4]. Also this file [5].
> >
> > It’s unclear how this file [6] is licensed and it may incorrectly have an
> > ASF header. On closer inspection there see to be a number of files which
> > might be 3rd party and incorrectly have an ASF header. [7] - [24]. You’ll
> > note these files have author tags. Where did these files come from?
> >
> > Some code in here [25] from this blog is licensed CC 4.0 BY_SA, this is
> > not compatible with the Apache license. [27]
> >
> > Do you have permission to use this code [28] from the authors and is it
> in
> > under an Apache license as the file header states?
> >
> > There are also a number of references to http://echarts.baidu.com in the
> > code which should probably change.
> >
> > You might want to consider using the work in progress disclaimer [29] and
> > documenting the issues in that until they are fixed.
> >
> > Thanks,
> > Justin
> >
> > 1. ./src/component/tooltip/TooltipContent.js
> > 2.
> >
> https://stackoverflow.com/questions/21125587/css3-transition-not-working-in-chrome-anymore
> > 3. https://apache.org/legal/resolved.html#stackoverflow
> > 4. https://issues.apache.org/jira/browse/LEGAL-471
> > 5. ./src/component/toolbox/feature/DataView.js
> > 6. ./src/chart/chord/chordCircularLayout.js
> > 7. ./src/util/KDTree.js
> > 8. ./src/util/quickSelect.js
> > 9. ./src/chart/tree/TreeSeries.js
> > 10. ./src/chart/tree/treeAction.js
> > 11. ./src/chart/tree/TreeView.js
> > 12. ./src/chart/sankey/sankeyAction.js
> > 13. ./src/chart/sankey/SankeySeries.js
> > 14. ./src/chart/sankey/sankeyLayout.js
> > 15. ./src/chart/sankey/SankeyView.js
> > 16. ./src/chart/sankey/sankeyVisual.js
> > 17. ./src/chart/themeRiver/themeRiverVisual.js
> > 18. ./src/chart/themeRiver/themeRiverLayout.js
> > 19. ./src/chart/themeRiver/ThemeRiverSeries.js
> > 20. ./src/chart/themeRiver/ThemeRiverView.js
> > 21. ./src/chart/heatmap/HeatmapLayer.js
> > 22, ./src/chart/chord/chordCircularLayout.js
> > 23. ./src/component/calendar.js
> > 24. ./src/data/Graph.js
> > 25. ./src/component/brush/selector.js
> > 26. http://blog.csdn.net/rickliuxiao/article/details/6259322
> > 27. https://apache.org/legal/resolved.html#cc-sa
> > 28. ./extension-src/dataTool/gexf.js
> > 29. https://incubator.apache.org/policy/incubation.html#disclaimers
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
> --
> Yi Shen
> Senior Developer
> Baidu, Inc.
>
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 1)
Posted by Yi Shen <sh...@gmail.com>.
Hi Justin,
1. The Stack Overflow link we referenced in file [1] is an explanation of
why this issue happens. We didn't use the code.
2. About files with author tags [6] - [24], it's because we used to add
author names at the beginning of files as a convention.
There are still some files keep it. They are not third party files
Author of files [6], [7], [8], [21], [22], [24] is me (shenyi@apache.org)
Author of files [9] - [20] is Deqing Li (deqingli@apache.org)
Author of file [23] is Xiaohong Deng. She is one of our contributors, but
not committer.
We will remove the author tags in these files.
3. I wrote the code of file [28]. It's a parser of GEXF file format.
The link in this file is broken. It's the specification of this format. The
new link is https://gephi.org/gexf/1.2draft/gexf-12draft-primer.pdf
4. We will remove the function related to the code from Stack Overflow in
file [5] and rewrite the code in file [26] before we start a new vote.
Thanks.
On Fri, Sep 6, 2019 at 7:33 AM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> -1 binding (release includes Category X licensed code)
>
> I checked:
> - signatures and hashes fine
> - DISCLAIMER exists
> - LICENSE may have some issues and missing some license information (see
> below)
> - NOTICE is fine
> - all source file have ASF headers
> - no unexpected binary files
>
> This file [1] contain code from [2] this is probably not compatible with
> the ALv2 [3][4]. Also this file [5].
>
> It’s unclear how this file [6] is licensed and it may incorrectly have an
> ASF header. On closer inspection there see to be a number of files which
> might be 3rd party and incorrectly have an ASF header. [7] - [24]. You’ll
> note these files have author tags. Where did these files come from?
>
> Some code in here [25] from this blog is licensed CC 4.0 BY_SA, this is
> not compatible with the Apache license. [27]
>
> Do you have permission to use this code [28] from the authors and is it in
> under an Apache license as the file header states?
>
> There are also a number of references to http://echarts.baidu.com in the
> code which should probably change.
>
> You might want to consider using the work in progress disclaimer [29] and
> documenting the issues in that until they are fixed.
>
> Thanks,
> Justin
>
> 1. ./src/component/tooltip/TooltipContent.js
> 2.
> https://stackoverflow.com/questions/21125587/css3-transition-not-working-in-chrome-anymore
> 3. https://apache.org/legal/resolved.html#stackoverflow
> 4. https://issues.apache.org/jira/browse/LEGAL-471
> 5. ./src/component/toolbox/feature/DataView.js
> 6. ./src/chart/chord/chordCircularLayout.js
> 7. ./src/util/KDTree.js
> 8. ./src/util/quickSelect.js
> 9. ./src/chart/tree/TreeSeries.js
> 10. ./src/chart/tree/treeAction.js
> 11. ./src/chart/tree/TreeView.js
> 12. ./src/chart/sankey/sankeyAction.js
> 13. ./src/chart/sankey/SankeySeries.js
> 14. ./src/chart/sankey/sankeyLayout.js
> 15. ./src/chart/sankey/SankeyView.js
> 16. ./src/chart/sankey/sankeyVisual.js
> 17. ./src/chart/themeRiver/themeRiverVisual.js
> 18. ./src/chart/themeRiver/themeRiverLayout.js
> 19. ./src/chart/themeRiver/ThemeRiverSeries.js
> 20. ./src/chart/themeRiver/ThemeRiverView.js
> 21. ./src/chart/heatmap/HeatmapLayer.js
> 22, ./src/chart/chord/chordCircularLayout.js
> 23. ./src/component/calendar.js
> 24. ./src/data/Graph.js
> 25. ./src/component/brush/selector.js
> 26. http://blog.csdn.net/rickliuxiao/article/details/6259322
> 27. https://apache.org/legal/resolved.html#cc-sa
> 28. ./extension-src/dataTool/gexf.js
> 29. https://incubator.apache.org/policy/incubation.html#disclaimers
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
--
Yi Shen
Senior Developer
Baidu, Inc.
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 1)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
-1 binding (release includes Category X licensed code)
I checked:
- signatures and hashes fine
- DISCLAIMER exists
- LICENSE may have some issues and missing some license information (see below)
- NOTICE is fine
- all source file have ASF headers
- no unexpected binary files
This file [1] contain code from [2] this is probably not compatible with the ALv2 [3][4]. Also this file [5].
It’s unclear how this file [6] is licensed and it may incorrectly have an ASF header. On closer inspection there see to be a number of files which might be 3rd party and incorrectly have an ASF header. [7] - [24]. You’ll note these files have author tags. Where did these files come from?
Some code in here [25] from this blog is licensed CC 4.0 BY_SA, this is not compatible with the Apache license. [27]
Do you have permission to use this code [28] from the authors and is it in under an Apache license as the file header states?
There are also a number of references to http://echarts.baidu.com in the code which should probably change.
You might want to consider using the work in progress disclaimer [29] and documenting the issues in that until they are fixed.
Thanks,
Justin
1. ./src/component/tooltip/TooltipContent.js
2. https://stackoverflow.com/questions/21125587/css3-transition-not-working-in-chrome-anymore
3. https://apache.org/legal/resolved.html#stackoverflow
4. https://issues.apache.org/jira/browse/LEGAL-471
5. ./src/component/toolbox/feature/DataView.js
6. ./src/chart/chord/chordCircularLayout.js
7. ./src/util/KDTree.js
8. ./src/util/quickSelect.js
9. ./src/chart/tree/TreeSeries.js
10. ./src/chart/tree/treeAction.js
11. ./src/chart/tree/TreeView.js
12. ./src/chart/sankey/sankeyAction.js
13. ./src/chart/sankey/SankeySeries.js
14. ./src/chart/sankey/sankeyLayout.js
15. ./src/chart/sankey/SankeyView.js
16. ./src/chart/sankey/sankeyVisual.js
17. ./src/chart/themeRiver/themeRiverVisual.js
18. ./src/chart/themeRiver/themeRiverLayout.js
19. ./src/chart/themeRiver/ThemeRiverSeries.js
20. ./src/chart/themeRiver/ThemeRiverView.js
21. ./src/chart/heatmap/HeatmapLayer.js
22, ./src/chart/chord/chordCircularLayout.js
23. ./src/component/calendar.js
24. ./src/data/Graph.js
25. ./src/component/brush/selector.js
26. http://blog.csdn.net/rickliuxiao/article/details/6259322
27. https://apache.org/legal/resolved.html#cc-sa
28. ./extension-src/dataTool/gexf.js
29. https://incubator.apache.org/policy/incubation.html#disclaimers
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 1)
Posted by ซ่อยค่อย ลืมเขาแน่ <09...@gmail.com>.
ในวันที่ พฤ. 5 ก.ย. 2019 15:01 SHUANG SU <su...@gmail.com> เขียนว่า:
> I am pleased to be calling this vote for the release of Apache ECharts
> (incubating) 4.3.0 (release candidate 1).
>
> Apache ECharts community has voted and approved the release.
>
> Vote thread:
>
> https://lists.apache.org/thread.html/e17e9a8d94c81019b073ef7f5cee9075d6921f01cdd8840f9618b012@%3Cdev.echarts.apache.org%3E
>
> Results thread:
>
> https://lists.apache.org/thread.html/0d52c6ed1e5d1b6bc72b56e1b240063577fde4d9cc3c227d33396caa@%3Cdev.echarts.apache.org%3E
>
> The release candidate to be voted over is available at:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.1/
>
> The release candidate is signed with a GPG key available at:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS
>
> The Git commit for this release is:
>
> https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=b62ab99
>
> The Release Note is available in:
>
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.1/RELEASE_NOTE.txt
>
> Some shell commands for validating the release:
>
> ```shell
> # Download the release:
> curl
>
> https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.1/apache-echarts-4.3.0-rc.1-incubating-src.zip
> -o apache-echarts-4.3.0-rc.1-incubating-src.zip
> unzip apache-echarts-4.3.0-rc.1-incubating-src.zip -d
> apache-echarts-4.3.0-rc.1-incubating-src > /dev/null
>
> # Rebuild the project (Node.js environment is required):
> cd "apache-echarts-4.3.0-rc.1-incubating-src" && npm install && cd ..
> node "apache-echarts-4.3.0-rc.1-incubating-src/build/build.js" --release
> # (See help: `node
> "apache-echarts-4.3.0-rc.1-incubating-src/build/build.js" --help`)
> ```
>
>
> Please vote on releasing this package as:
> Apache ECharts (incubating) 4.3.0 (release candidate 1)
> by "2019-09-08T08:57:30.519Z".
>
> [ ] +1 Release this package
> [ ] 0 I don't feel strongly about it, but don't object
> [ ] -1 Do not release this package because...
>
> Anyone can participate in testing and voting, not just committers, please
> feel free to try out the release candidate and provide your votes.
>
> A checklist for reference:
>
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>
> Thanks,
> ------------------------------
> Su Shuang (100pah)
> ------------------------------
>