You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by caofangkun <gi...@git.apache.org> on 2015/07/17 11:51:09 UTC

[GitHub] storm pull request: STORM-947: replace all `backtype.storm.schedul...

GitHub user caofangkun opened a pull request:

    https://github.com/apache/storm/pull/640

    STORM-947:  replace all  `backtype.storm.scheduler.ExecutorDetails`  with `backtype.storm.generated.ExecutorInfo `

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/caofangkun/apache-storm storm-947

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/640.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #640
    
----
commit 713de61c6a32bbb7d54033112f27222f03d9bad4
Author: caofangkun <ca...@gmail.com>
Date:   2015-07-17T09:47:47Z

    STORM-947: replace all    with

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-947: replace all `backtype.storm.schedul...

Posted by chuanlei <gi...@git.apache.org>.
Github user chuanlei commented on the pull request:

    https://github.com/apache/storm/pull/640#issuecomment-122239340
  
    I think it is good since `ExecutorDetails` does not take more information. And this change make Storm code more concise.
    
    But I'm sure whether `ExecutorDetails` is designed for extension in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-947: replace all `backtype.storm.schedul...

Posted by chuanlei <gi...@git.apache.org>.
Github user chuanlei commented on a diff in the pull request:

    https://github.com/apache/storm/pull/640#discussion_r34878435
  
    --- Diff: storm-core/src/clj/backtype/storm/scheduler/DefaultScheduler.clj ---
    @@ -18,7 +18,7 @@
       (:require [backtype.storm.scheduler.EvenScheduler :as EvenScheduler])
       (:import [backtype.storm.scheduler IScheduler Topologies
                 Cluster TopologyDetails WorkerSlot SchedulerAssignment
    -            EvenScheduler ExecutorDetails])
    +            EvenScheduler])
    --- End diff --
    
    So, is the original import unnecessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #640: STORM-947: replace all `backtype.storm.scheduler.Ex...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/640


---

[GitHub] storm pull request: STORM-947: replace all `backtype.storm.schedul...

Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on a diff in the pull request:

    https://github.com/apache/storm/pull/640#discussion_r35073778
  
    --- Diff: storm-core/src/clj/backtype/storm/scheduler/DefaultScheduler.clj ---
    @@ -18,7 +18,7 @@
       (:require [backtype.storm.scheduler.EvenScheduler :as EvenScheduler])
       (:import [backtype.storm.scheduler IScheduler Topologies
                 Cluster TopologyDetails WorkerSlot SchedulerAssignment
    -            EvenScheduler ExecutorDetails])
    +            EvenScheduler])
    --- End diff --
    
    @chuanlei 
    Yes, It's unnecessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---