You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/07/12 17:43:06 UTC

[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on issue #4: AMQNET-589: Failover implementation

cjwmorgan-sol commented on issue #4: AMQNET-589: Failover implementation
URL: https://github.com/apache/activemq-nms-amqp/pull/4#issuecomment-510972890
 
 
   > @cjwmorgan-sol
   > 
   > 1. Can you please confirm that send timeout -1 doesn't work, because from what I've checked, it should work just fine (otherwise most of producer tests would fail). Underlying ManualResetEvent WaitOne method is being invoked with -1 parameter which results in waiting forever. Exactly what the spec says.
   
   You're right thanks for that. I found that issue while running TestSendWhenLinkCreditIsZeroAndTimeout (modified for sendTimeout -1). The issue I saw was the waitOne threw an exception "Thread Abort" when the test would timeout after 2000ms while debugging.  Send Timeout works fine as intended.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services