[GitHub] [spark] cxzl25 commented on a change in pull request #26577: [SPARK-29943][SQL] Improve error messages for unsupported data type

[GitBox <gi...@apache.org>]

cxzl25 commented on a change in pull request #26577: [SPARK-29943][SQL] Improve error messages for unsupported data type
URL: https://github.com/apache/spark/pull/26577#discussion_r352440390
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
 ##########
 @@ -493,8 +493,9 @@ private[spark] object HiveUtils extends Logging {
       val hiveTable = HiveClientImpl.toHiveTable(table)
       // Note: Hive separates partition columns and the schema, but for us the
       // partition columns are part of the schema
-      val partCols = hiveTable.getPartCols.asScala.map(HiveClientImpl.fromHiveColumn)
-      val dataCols = hiveTable.getCols.asScala.map(HiveClientImpl.fromHiveColumn)
+      val partCols = hiveTable.getPartCols.asScala.map(c =>
 
 Review comment:
   ok. i changed to rethrow exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org