You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/21 07:30:07 UTC
[GitHub] [incubator-nuttx] XuNeo opened a new pull request, #7634: drivers/segger: make RTT_MODE configurable
XuNeo opened a new pull request, #7634:
URL: https://github.com/apache/incubator-nuttx/pull/7634
Configure segger RTT_MODE through Kconfig
## Summary
Change default RTT_MODE to NO_BLOCK_SKIP, so code can run without debugger connected.
## Impact
Default mode is changed.
## Testing
Tested with stm32f1, syslog works as usual.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7634: drivers/segger: make RTT_MODE configurable
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7634:
URL: https://github.com/apache/incubator-nuttx/pull/7634#discussion_r1027663970
##########
drivers/segger/Kconfig:
##########
@@ -62,6 +62,21 @@ config SEGGER_RTT_BUFFER_SIZE_DOWN
---help---
Size of the buffer for terminal input to target from host (Usually keyboard input)
+choice
+ prompt "SEGGER_RTT_MODE"
+ default SEGGER_RTT_MODE_NO_BLOCK_SKIP
Review Comment:
should we default to SEGGER_RTT_MODE_BLOCK_IF_FIFO_FULL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] XuNeo commented on a diff in pull request #7634: drivers/segger: make RTT_MODE configurable
Posted by GitBox <gi...@apache.org>.
XuNeo commented on code in PR #7634:
URL: https://github.com/apache/incubator-nuttx/pull/7634#discussion_r1027671457
##########
drivers/segger/Kconfig:
##########
@@ -62,6 +62,21 @@ config SEGGER_RTT_BUFFER_SIZE_DOWN
---help---
Size of the buffer for terminal input to target from host (Usually keyboard input)
+choice
+ prompt "SEGGER_RTT_MODE"
+ default SEGGER_RTT_MODE_NO_BLOCK_SKIP
Review Comment:
The default option in SEGGER_RTT.c is set to SEGGER_RTT_MODE_NO_BLOCK_SKIP.
If default to block mode, the board will stuck when debugger disconnected, so we have to build the code again with non-block mode when test on field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7634: drivers/segger: make RTT_MODE configurable
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7634:
URL: https://github.com/apache/incubator-nuttx/pull/7634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org