[GitHub] [drill] luocooong commented on pull request #2389: DRILL-8060: Avoid the NPE in the Filter of Iceberg Implementor

[GitBox <gi...@apache.org>]

luocooong commented on pull request #2389:
URL: https://github.com/apache/drill/pull/2389#issuecomment-1007949898


   @vvysotskyi Thanks for the information. The previous decision to add Input Conversion was due to a new ERROR with the addition of unit tests, refer to :
   ```
   Caused by: java.lang.AssertionError: rowtype mismatches expressions
     at org.apache.calcite.util.Litmus$1.fail(Litmus.java:31)
     at org.apache.calcite.rex.RexUtil.compatibleTypes(RexUtil.java:967)
     at org.apache.calcite.rel.core.Project.isValid(Project.java:185)
     at org.apache.calcite.rel.core.Project.<init>(Project.java:83)
     at org.apache.drill.exec.planner.common.DrillProjectRelBase.<init>(DrillProjectRelBase.java:67)
     at org.apache.drill.exec.store.plan.rel.PluginProjectRel.<init>(PluginProjectRel.java:43)
     at org.apache.drill.exec.store.plan.rule.PluginProjectRule.createPluginProject(PluginProjectRule.java:93)
     at org.apache.drill.exec.store.plan.rule.PluginProjectRule.convert(PluginProjectRule.java:68)
     at org.apache.calcite.rel.convert.ConverterRule.onMatch(ConverterRule.java:144)
     at org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:208)
     at org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:633)
     at org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:327)
     at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:405)
     at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:351)
     at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToRawDrel(DefaultSqlHandler.java:245)
     at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToDrel(DefaultSqlHandler.java:308)
     at org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.getPlan(DefaultSqlHandler.java:173)
     at org.apache.drill.exec.planner.sql.DrillSqlWorker.getQueryPlan(DrillSqlWorker.java:283)
     at org.apache.drill.exec.planner.sql.DrillSqlWorker.getPhysicalPlan(DrillSqlWorker.java:163)
     at org.apache.drill.exec.planner.sql.DrillSqlWorker.convertPlan(DrillSqlWorker.java:128)
     at org.apache.drill.exec.planner.sql.DrillSqlWorker.getPlan(DrillSqlWorker.java:93)
     at org.apache.drill.exec.work.foreman.Foreman.runSQL(Foreman.java:593)
     at org.apache.drill.exec.work.foreman.Foreman.run(Foreman.java:274)
     ... 1 more
   ```
   If there is a way to not rely on Input Conversion, that might be better, please let me know, thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org