You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/07 09:35:43 UTC

[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #4: remove mima checks

jrudolph commented on code in PR #4:
URL: https://github.com/apache/incubator-pekko-http/pull/4#discussion_r1015195236


##########
project/ValidatePullRequest.scala:
##########
@@ -360,9 +359,12 @@ object AggregatePRValidation extends AutoPlugin {
         case KeyValue(key, i: Inc) => KeyValue(key, i)
       }
 
+      /*

Review Comment:
   Maybe we can keep this file as is and just remove the versions to check against in `project/Mima.scala`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org