You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Collins-Sussman <su...@newton.ch.collab.net> on 2001/04/10 15:42:33 UTC
Re: CVS update: subversion/subversion/libsvn_fs editor.c
cmpilato@tigris.org writes:
> * libsvn_fs/editor.c
>
> (close_file): Bug fix: it pains me to see us freeing stuff out of
> order. Ouch.
Doh!
<embarrassment>
Re: CVS update: subversion/subversion/libsvn_fs editor.c
Posted by cm...@collab.net.
Karl Fogel <kf...@collab.net> writes:
> Yep, unless they have some really annoying user-visible behavior.
> This is development code, let's make it friendly for developers. :-)
Some of them do. For example, #define-ing ALLOC_STATS registers an
atexit() function that prints pool usage stats to stderr. Others
don't. However, I'm not seeing anything really useful with these
turned on, so I'm not going to commit code with those flags enabled.
Re: CVS update: subversion/subversion/libsvn_fs editor.c
Posted by Karl Fogel <kf...@collab.net>.
cmpilato@collab.net writes:
> Been thinkin' the same thing. Should we turn them on for everyone
> (meaning, check in the addition of APR pool debug flags) ?
Yep, unless they have some really annoying user-visible behavior.
This is development code, let's make it friendly for developers. :-)
Re: CVS update: subversion/subversion/libsvn_fs editor.c
Posted by Greg Stein <gs...@lyra.org>.
On Wed, Apr 11, 2001 at 09:01:28AM -0500, cmpilato@collab.net wrote:
> Greg Stein <gs...@lyra.org> writes:
>
> > Hmm. I just thought about someting. apr_pools.[ch] has some debugging flags.
> > It might be useful to turn those on and see what happens. Some failures
> > could crop up.
>
> Been thinkin' the same thing. Should we turn them on for everyone
> (meaning, check in the addition of APR pool debug flags) ?
That might be a bit extreme. I'd suggest just editing them in your local
copy of apr_pools.h and go with that.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: CVS update: subversion/subversion/libsvn_fs editor.c
Posted by cm...@collab.net.
Greg Stein <gs...@lyra.org> writes:
> Hmm. I just thought about someting. apr_pools.[ch] has some debugging flags.
> It might be useful to turn those on and see what happens. Some failures
> could crop up.
Been thinkin' the same thing. Should we turn them on for everyone
(meaning, check in the addition of APR pool debug flags) ?
Re: CVS update: subversion/subversion/libsvn_fs editor.c
Posted by Greg Stein <gs...@lyra.org>.
On Tue, Apr 10, 2001 at 10:42:33AM -0500, Ben Collins-Sussman wrote:
> cmpilato@tigris.org writes:
>
> > * libsvn_fs/editor.c
> >
> > (close_file): Bug fix: it pains me to see us freeing stuff out of
> > order. Ouch.
>
> Doh!
>
> <embarrassment>
Hmm. I just thought about someting. apr_pools.[ch] has some debugging flags.
It might be useful to turn those on and see what happens. Some failures
could crop up.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/