You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Tricia Jenkins (JIRA)" <ji...@apache.org> on 2013/01/19 00:08:12 UTC
[jira] [Updated] (SOLR-4317) SolrTestCaseJ4: Can't avoid
"collection1" convention
[ https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tricia Jenkins updated SOLR-4317:
---------------------------------
Attachment: SOLR-4317.patch
This is the patch from my description.
> SolrTestCaseJ4: Can't avoid "collection1" convention
> ----------------------------------------------------
>
> Key: SOLR-4317
> URL: https://issues.apache.org/jira/browse/SOLR-4317
> Project: Solr
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 4.0
> Reporter: Tricia Jenkins
> Priority: Minor
> Fix For: 4.1
>
> Attachments: SOLR-4317.patch
>
>
> I think that there is still an issue after the SOLR-3826 patch was applied for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012. This line is missing:
> Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> ===================================================================
> --- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java (revision 1435375)
> +++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java (working copy)
> @@ -384,9 +384,9 @@
> public static void createCore() {
> assertNotNull(testSolrHome);
> solrConfig = TestHarness.createConfig(testSolrHome, coreName, getSolrConfigFile());
> - h = new TestHarness( dataDir.getAbsolutePath(),
> + h = new TestHarness( coreName, new Initializer( coreName, dataDir.getAbsolutePath(),
> solrConfig,
> - getSchemaFile());
> + getSchemaFile() ) );
> lrf = h.getRequestFactory
> ("standard",0,20,CommonParams.VERSION,"2.2");
> }
> TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema indexSchema) sets coreName to null and opens the default core: collection1. I would expect that coreName is carried all the way through the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org