[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8498: Make more fs API available when CONFIG_DISABLE_MOUNTPOINT isn't enabled

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on PR #8498:
URL: https://github.com/apache/nuttx/pull/8498#issuecomment-1426621444

   > @xiaoxiang781216 why fsync is needed after his modifcation to fread/fwrite/* to read/write/* ?
   > 
   
   Since @no1wudi map fflush to fsync. But since fflush just flush the buffer in sdio layer to vfs layer, it's enough to only remove fflush.
   
   > Since previous mofication was decreasing the firmware size by some KBs, could you please get the new size after including fsync by default?
   
   Th3 size reported by @no1wudi should already include the consumption from fsync, otherwise we can't get the final image. Thanks you point out fsync issue, the size will decrease more:). @no1wudi please report the new size after removing fflush in https://github.com/apache/nuttx-apps/pull/1559.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org