You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/09 09:21:38 UTC

[GitHub] [apisix] dickens7 commented on pull request #2193: fixed #2191

dickens7 commented on pull request #2193:
URL: https://github.com/apache/apisix/pull/2193#issuecomment-689441251


   I think it’s not a good idea to remove the sample variable, I moved the sample decision logic to create_tracer function. Keep upstream decided to sample the request, we do too.
   发送自 Windows 10 版邮件
   
   发件人: Wen Ming
   发送时间: 2020年9月9日 16:20
   收件人: apache/apisix
   抄送: seven dickens; Author
   主题: Re: [apache/apisix] fixed #2191 (#2193)
   
       apisix/plugins/zipkin/codec.lua:41:13: value assigned to variable sample is unused
   please remove sample variable, thx
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub, or unsubscribe.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org