[GitHub] [apisix-ingress-controller] Belyenochi commented on a change in pull request #920: fix: export apisix type for encoding/json package

[GitBox <gi...@apache.org>]

Belyenochi commented on a change in pull request #920:
URL: https://github.com/apache/apisix-ingress-controller/pull/920#discussion_r829008892



##########
File path: pkg/kube/apisix_route.go
##########
@@ -54,21 +54,21 @@ type ApisixRouteInformer interface {
 // ApisixRoute is an encapsulation for ApisixRoute resource with different
 // versions, for now, they are apisix.apache.org/v1 and apisix.apache.org/v2alpha1
 type ApisixRoute interface {
-	// GroupVersion returns the api group version of the
+	// GetGroupVersion returns the api group version of the

Review comment:
       @tokers  Thanks for your suggestion, I have another optimization idea, we could provide factory function that returns a concrete implementation runtime.Object for the given GVK instand of kube/apisix_route.go(or ingress.go etcd).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org