You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Enrico Olivelli <eo...@gmail.com> on 2017/10/01 14:00:05 UTC
Re: Maven Surefire and JUnit 5
Benedikt,
did you try to update all of your maven plugins to latest version?
Can you share some stacktrace? This will give a first hint without having
to build jUDDI
Cheers
Enrico
Il sab 30 set 2017, 10:34 Benedikt Ritter <br...@apache.org> ha scritto:
> Hello,
>
> for over a year now I’m trying to help getting JUnit 5 support into Maven
> Surefire. This has been hard since Tibor seems to be the only one
> maintaining Maven Surefire and he had to come with other things.
>
> For this reason I’d like to ask other Maven maintainers to help with the
> JUnit 5 support. I’m happy to do the work, but I’m constantly blocked by
> obscure build failures which I’m unable to resolve myself or by lack of
> code review und merge of changes.
>
> - Work on JUnit5 support is currently done in the junit5 branch.
> - I have drafted a Provider Lookup implementation in the junit5 branch,
> but I don’t know whether it works because I can’t get the integration tests
> running
> - There is an open PR to merge the master branch back into junit5 branch,
> but it has build failures I don’t understand [1]
>
> Please help!
> Cheers,
> Benedikt
>
> [1] https://github.com/apache/maven-surefire/pull/165
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
> --
-- Enrico Olivelli
Re: Maven Surefire and JUnit 5
Posted by Benedikt Ritter <br...@apache.org>.
Hello Tibor
> Am 06.10.2017 um 01:18 schrieb Tibor Digana <ti...@googlemail.com>:
>
> Hi Benedikt,
>
> Would you agree with this plan.
> Since we try to release version 2.21.0 with Jigsaw modularity which is Java 9 related feature, we can make the same compromise with JUnit5 in next version 2.22.0. Altough Surifire is compiled with javac -source 1.6 -target 1.6, and JUnit 5/Java 1.8 provider is standalone jar file which does not force the plugin itself to load Java 8 classes from the provider, we can freely work on JUnit 5 provider after the version 2.21.0.Jigsaw has been released. I guess I will start the release Vote next week and then we can pickup your commits from the branch junit5, squash them into one single commit and rebase on the top of future master/HEAD.
> I believe you want to merge some more fixes from JUnit team afterwards and maybe to add some more tests.
>
> What do you think, would it be possible for you?
This would be so great! I’m currently really blocked by the fact, that I can’t run the surefire build without errors. If you could help fix this, maybe by rebasing everything, this would be very much appreciated.
Looking forward to hearing from you!
Regards,
Benedikt
>
> Cheers
> Tibor
>
> On Sun, Oct 1, 2017 at 5:12 PM, Enrico Olivelli <eo...@gmail.com> wrote:
> Sorry
> I wanted to reply to another message from Benedikt
> Enrico
>
> Il dom 1 ott 2017, 16:17 Karl Heinz Marbaise <kh...@gmx.de> ha scritto:
>
> > Hi Enrico,
> >
> > On 01/10/17 16:00, Enrico Olivelli wrote:
> > > Benedikt,
> > > did you try to update all of your maven plugins to latest version?
> > > Can you share some stacktrace? This will give a first hint without having
> > > to build jUDDI
> >
> > This is the wrong mailing list...Users list was the subject about jUDDI
> > ;-)..
> >
> > Not related to Surefire and JUnit 5 ...
> >
> > Kind regards
> > Karl Heinz Marbaise
> > > Cheers
> > >
> > > Enrico
> > >
> > > Il sab 30 set 2017, 10:34 Benedikt Ritter <br...@apache.org> ha
> > scritto:
> > >
> > >> Hello,
> > >>
> > >> for over a year now I’m trying to help getting JUnit 5 support into
> > Maven
> > >> Surefire. This has been hard since Tibor seems to be the only one
> > >> maintaining Maven Surefire and he had to come with other things.
> > >>
> > >> For this reason I’d like to ask other Maven maintainers to help with the
> > >> JUnit 5 support. I’m happy to do the work, but I’m constantly blocked by
> > >> obscure build failures which I’m unable to resolve myself or by lack of
> > >> code review und merge of changes.
> > >>
> > >> - Work on JUnit5 support is currently done in the junit5 branch.
> > >> - I have drafted a Provider Lookup implementation in the junit5 branch,
> > >> but I don’t know whether it works because I can’t get the integration
> > tests
> > >> running
> > >> - There is an open PR to merge the master branch back into junit5
> > branch,
> > >> but it has build failures I don’t understand [1]
> > >>
> > >> Please help!
> > >> Cheers,
> > >> Benedikt
> >
> --
>
>
> -- Enrico Olivelli
>
>
>
> --
> Cheers
> Tibor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven Surefire and JUnit 5
Posted by Tibor Digana <ti...@googlemail.com>.
Hi Benedikt,
Would you agree with this plan.
Since we try to release version 2.21.0 with Jigsaw modularity which is Java
9 related feature, we can make the same compromise with JUnit5 in next
version 2.22.0. Altough Surifire is compiled with javac -source 1.6 -target
1.6, and JUnit 5/Java 1.8 provider is standalone jar file which does not
force the plugin itself to load Java 8 classes from the provider, we can
freely work on JUnit 5 provider after the version 2.21.0.Jigsaw has been
released. I guess I will start the release Vote next week and then we can
pickup your commits from the branch junit5, squash them into one single
commit and rebase on the top of future master/HEAD.
I believe you want to merge some more fixes from JUnit team afterwards and
maybe to add some more tests.
What do you think, would it be possible for you?
Cheers
Tibor
On Sun, Oct 1, 2017 at 5:12 PM, Enrico Olivelli <eo...@gmail.com> wrote:
> Sorry
> I wanted to reply to another message from Benedikt
> Enrico
>
> Il dom 1 ott 2017, 16:17 Karl Heinz Marbaise <kh...@gmx.de> ha
> scritto:
>
> > Hi Enrico,
> >
> > On 01/10/17 16:00, Enrico Olivelli wrote:
> > > Benedikt,
> > > did you try to update all of your maven plugins to latest version?
> > > Can you share some stacktrace? This will give a first hint without
> having
> > > to build jUDDI
> >
> > This is the wrong mailing list...Users list was the subject about jUDDI
> > ;-)..
> >
> > Not related to Surefire and JUnit 5 ...
> >
> > Kind regards
> > Karl Heinz Marbaise
> > > Cheers
> > >
> > > Enrico
> > >
> > > Il sab 30 set 2017, 10:34 Benedikt Ritter <br...@apache.org> ha
> > scritto:
> > >
> > >> Hello,
> > >>
> > >> for over a year now I’m trying to help getting JUnit 5 support into
> > Maven
> > >> Surefire. This has been hard since Tibor seems to be the only one
> > >> maintaining Maven Surefire and he had to come with other things.
> > >>
> > >> For this reason I’d like to ask other Maven maintainers to help with
> the
> > >> JUnit 5 support. I’m happy to do the work, but I’m constantly blocked
> by
> > >> obscure build failures which I’m unable to resolve myself or by lack
> of
> > >> code review und merge of changes.
> > >>
> > >> - Work on JUnit5 support is currently done in the junit5 branch.
> > >> - I have drafted a Provider Lookup implementation in the junit5
> branch,
> > >> but I don’t know whether it works because I can’t get the integration
> > tests
> > >> running
> > >> - There is an open PR to merge the master branch back into junit5
> > branch,
> > >> but it has build failures I don’t understand [1]
> > >>
> > >> Please help!
> > >> Cheers,
> > >> Benedikt
> >
> --
>
>
> -- Enrico Olivelli
>
--
Cheers
Tibor
Re: Maven Surefire and JUnit 5
Posted by Enrico Olivelli <eo...@gmail.com>.
Sorry
I wanted to reply to another message from Benedikt
Enrico
Il dom 1 ott 2017, 16:17 Karl Heinz Marbaise <kh...@gmx.de> ha scritto:
> Hi Enrico,
>
> On 01/10/17 16:00, Enrico Olivelli wrote:
> > Benedikt,
> > did you try to update all of your maven plugins to latest version?
> > Can you share some stacktrace? This will give a first hint without having
> > to build jUDDI
>
> This is the wrong mailing list...Users list was the subject about jUDDI
> ;-)..
>
> Not related to Surefire and JUnit 5 ...
>
> Kind regards
> Karl Heinz Marbaise
> > Cheers
> >
> > Enrico
> >
> > Il sab 30 set 2017, 10:34 Benedikt Ritter <br...@apache.org> ha
> scritto:
> >
> >> Hello,
> >>
> >> for over a year now I’m trying to help getting JUnit 5 support into
> Maven
> >> Surefire. This has been hard since Tibor seems to be the only one
> >> maintaining Maven Surefire and he had to come with other things.
> >>
> >> For this reason I’d like to ask other Maven maintainers to help with the
> >> JUnit 5 support. I’m happy to do the work, but I’m constantly blocked by
> >> obscure build failures which I’m unable to resolve myself or by lack of
> >> code review und merge of changes.
> >>
> >> - Work on JUnit5 support is currently done in the junit5 branch.
> >> - I have drafted a Provider Lookup implementation in the junit5 branch,
> >> but I don’t know whether it works because I can’t get the integration
> tests
> >> running
> >> - There is an open PR to merge the master branch back into junit5
> branch,
> >> but it has build failures I don’t understand [1]
> >>
> >> Please help!
> >> Cheers,
> >> Benedikt
>
--
-- Enrico Olivelli
Re: Maven Surefire and JUnit 5
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Enrico,
On 01/10/17 16:00, Enrico Olivelli wrote:
> Benedikt,
> did you try to update all of your maven plugins to latest version?
> Can you share some stacktrace? This will give a first hint without having
> to build jUDDI
This is the wrong mailing list...Users list was the subject about jUDDI
;-)..
Not related to Surefire and JUnit 5 ...
Kind regards
Karl Heinz Marbaise
> Cheers
>
> Enrico
>
> Il sab 30 set 2017, 10:34 Benedikt Ritter <br...@apache.org> ha scritto:
>
>> Hello,
>>
>> for over a year now I’m trying to help getting JUnit 5 support into Maven
>> Surefire. This has been hard since Tibor seems to be the only one
>> maintaining Maven Surefire and he had to come with other things.
>>
>> For this reason I’d like to ask other Maven maintainers to help with the
>> JUnit 5 support. I’m happy to do the work, but I’m constantly blocked by
>> obscure build failures which I’m unable to resolve myself or by lack of
>> code review und merge of changes.
>>
>> - Work on JUnit5 support is currently done in the junit5 branch.
>> - I have drafted a Provider Lookup implementation in the junit5 branch,
>> but I don’t know whether it works because I can’t get the integration tests
>> running
>> - There is an open PR to merge the master branch back into junit5 branch,
>> but it has build failures I don’t understand [1]
>>
>> Please help!
>> Cheers,
>> Benedikt
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org