[GitHub] spark pull request: [SPARK-12221] add cpu time to metrics

[jisookim0513 <gi...@git.apache.org>]

Github user jisookim0513 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10212#discussion_r54951079
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -718,6 +719,7 @@ private[spark] object JsonProtocol {
         metrics.setHostname((json \ "Host Name").extract[String])
         metrics.setExecutorDeserializeTime((json \ "Executor Deserialize Time").extract[Long])
         metrics.setExecutorRunTime((json \ "Executor Run Time").extract[Long])
    +    metrics.setExecutorCpuTime((json \ "Executor CPU Time").extract[Long])
    --- End diff --
    
    Yeah it won't be able to deserialize a history from an earlier version. Would it be better to make this backward-compatible? (Sorry for the super late response)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org