You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/01/23 00:02:47 UTC
[GitHub] [guacamole-server] dkmstr opened a new pull request #253: GUACAMOLE
625: Included Latin American keymap
dkmstr opened a new pull request #253: GUACAMOLE 625: Included Latin American keymap
URL: https://github.com/apache/guacamole-server/pull/253
I have recreated the patch with a new clean guacamole-server
Hope this solves everything now.
Best Regards,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] necouchman commented on issue #253: GUACAMOLE
625: Included Latin American keymap
Posted by GitBox <gi...@apache.org>.
necouchman commented on issue #253: GUACAMOLE 625: Included Latin American keymap
URL: https://github.com/apache/guacamole-server/pull/253#issuecomment-578032168
Ah, actually @dkmstr, one minor thing. You titled both the PR and the commit with "GUACAMOLE 625" and not "GUACAMOLE-625" (dash instead of a space). This seems like a minor thing, but it helps us keep commits coming in from different places consistent, so please correct both of those.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] mike-jumper commented on issue #253: GUACAMOLE
625: Included Latin American keymap
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on issue #253: GUACAMOLE 625: Included Latin American keymap
URL: https://github.com/apache/guacamole-server/pull/253#issuecomment-578041136
A minor inconsistency in that JIRA issue prefix has definitely bitten me pretty hard before when grepping the git logs. It's not too bad when reading commit messages individually as a human, but it makes things tricky for anything automated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] necouchman merged pull request #253:
GUACAMOLE-625: Included Latin American keymap
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #253: GUACAMOLE-625: Included Latin American keymap
URL: https://github.com/apache/guacamole-server/pull/253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] mike-jumper commented on issue #253: GUACAMOLE
625: Included Latin American keymap
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on issue #253: GUACAMOLE 625: Included Latin American keymap
URL: https://github.com/apache/guacamole-server/pull/253#issuecomment-578041379
And, yes, looks good to me (except for that missing dash). ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] dkmstr commented on issue #253: GUACAMOLE 625:
Included Latin American keymap
Posted by GitBox <gi...@apache.org>.
dkmstr commented on issue #253: GUACAMOLE 625: Included Latin American keymap
URL: https://github.com/apache/guacamole-server/pull/253#issuecomment-578062904
Hope this is fine now, sorry for the mistake :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services