You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2017/03/14 21:14:32 UTC
[GitHub] beam pull request #2246: [BEAM-1721] Do not shift Timestamps forwards in Res...
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2246
[BEAM-1721] Do not shift Timestamps forwards in Reshuffle
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Timestamps can be shifted forwards after the fact, but cannot generally
be shifted backwards. Because reshuffle outputs "as quickly as
possible", only elements that arrive approximately simulatenously with
each other will have their timestamps shifted.
There is currently no way to output all input elements with their
original timestamps without explicitly reifying those timestamps and
reassigning them on the output elements.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam reshuffle_output_time_fn
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2246
----
commit 347250b80fafecbdb12059233255e526370a1623
Author: Thomas Groh <tg...@google.com>
Date: 2017-03-14T21:05:44Z
Do not shift Timestamps forwards in Reshuffle
Timestamps can be shifted forwards after the fact, but cannot generally
be shifted backwards. Because reshuffle outputs "as quickly as
possible", only elements that arrive approximately simulatenously with
each other will have their timestamps shifted.
There is currently no way to output all input elements with their
original timestamps without explicitly reifying those timestamps and
reassigning them on the output elements.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2246: [BEAM-1721] Do not shift Timestamps forwards in Res...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2246
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---