You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org> on 2017/11/20 16:25:02 UTC
Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/
-----------------------------------------------------------
Review request for sentry, Na Li and Sergio Pena.
Bugs: SENTRY-2034
https://issues.apache.org/jira/browse/SENTRY-2034
Repository: sentry
Description
-------
Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 95bbaeb5a678ee4b1e7adaab9985346027ecfc24
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 3c8b70ec3db59a4e6de6a7fb8b1509c4fe228c25
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc354c3b4e5b21456ee9a471253ffa4624f17
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0
Diff: https://reviews.apache.org/r/63958/diff/1/
Testing
-------
Made sure that new tests added and all the older tests pass.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/#review193972
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java
Lines 21-22 (patched)
<https://reviews.apache.org/r/63958/#comment272665>
There are a few commented lines here we should remove.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java
Lines 73 (patched)
<https://reviews.apache.org/r/63958/#comment272667>
Is there a better way to wait for HMS processing instead of waiting 5s? These 5s will increment testing time and believe hte processing is faster than than.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java
Lines 20-33 (patched)
<https://reviews.apache.org/r/63958/#comment272664>
There are a few commented lines here we should remove.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java
Lines 45 (patched)
<https://reviews.apache.org/r/63958/#comment272666>
This method name confuses a little the verifyPrivilegeDropped(). Can we rename it to verifyAllPrivilegesDropped()?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
Lines 52-54 (patched)
<https://reviews.apache.org/r/63958/#comment272663>
I see it exists a hdfsSyncEnabled variable on TestHDFSIntegrationBase which sets these properties. Can we use that variable instead?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
Lines 52-54 (patched)
<https://reviews.apache.org/r/63958/#comment272661>
I see it exists a hdfsSyncEnabled variable on TestHDFSIntegrationBase which sets these properties. Can we use that variable instead?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java
Lines 27-29 (patched)
<https://reviews.apache.org/r/63958/#comment272662>
I see it exists a hdfsSyncEnabled variable on TestHDFSIntegrationBase which sets these properties. Can we use that variable instead?
- Sergio Pena
On Dec. 5, 2017, 9:09 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63958/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 9:09 p.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2034
> https://issues.apache.org/jira/browse/SENTRY-2034
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57134b20189aa10bee48f6aae765a1a1830
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java c8eef09ed61e11583838a3dfd3117a9478df23ba
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc354c3b4e5b21456ee9a471253ffa4624f17
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0
>
>
> Diff: https://reviews.apache.org/r/63958/diff/3/
>
>
> Testing
> -------
>
> Made sure that new tests added and all the older tests pass.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/#review193939
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Dec. 5, 2017, 9:09 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63958/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 9:09 p.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2034
> https://issues.apache.org/jira/browse/SENTRY-2034
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57134b20189aa10bee48f6aae765a1a1830
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java c8eef09ed61e11583838a3dfd3117a9478df23ba
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc354c3b4e5b21456ee9a471253ffa4624f17
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0
>
>
> Diff: https://reviews.apache.org/r/63958/diff/3/
>
>
> Testing
> -------
>
> Made sure that new tests added and all the older tests pass.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/#review195470
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Jan. 11, 2018, 7:44 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63958/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2018, 7:44 p.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2034
> https://issues.apache.org/jira/browse/SENTRY-2034
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57134b20189aa10bee48f6aae765a1a1830
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java c8eef09ed61e11583838a3dfd3117a9478df23ba
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java a909b913e9d2342a7f76a886d3fdabdb1e309b9f
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java cc0449b1d1d0291049cb1fafebb6d752dd426fbc
>
>
> Diff: https://reviews.apache.org/r/63958/diff/4/
>
>
> Testing
> -------
>
> Made sure that new tests added and all the older tests pass.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/
-----------------------------------------------------------
(Updated Jan. 11, 2018, 7:44 p.m.)
Review request for sentry, Na Li and Sergio Pena.
Changes
-------
Addressed review comments from sergio.
Bugs: SENTRY-2034
https://issues.apache.org/jira/browse/SENTRY-2034
Repository: sentry
Description
-------
Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57134b20189aa10bee48f6aae765a1a1830
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java c8eef09ed61e11583838a3dfd3117a9478df23ba
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java a909b913e9d2342a7f76a886d3fdabdb1e309b9f
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java cc0449b1d1d0291049cb1fafebb6d752dd426fbc
Diff: https://reviews.apache.org/r/63958/diff/4/
Changes: https://reviews.apache.org/r/63958/diff/3-4/
Testing
-------
Made sure that new tests added and all the older tests pass.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/#review191548
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
Lines 52-54 (patched)
<https://reviews.apache.org/r/63958/#comment269394>
Values for these properties will vary based on the configuration that is why I moved them out of TestHDFIntegrationBase.
I did not want to refoctor the class. I've limited the changes that I actually need.
- kalyan kumar kalvagadda
On Dec. 5, 2017, 9:09 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63958/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 9:09 p.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2034
> https://issues.apache.org/jira/browse/SENTRY-2034
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57134b20189aa10bee48f6aae765a1a1830
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java c8eef09ed61e11583838a3dfd3117a9478df23ba
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc354c3b4e5b21456ee9a471253ffa4624f17
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0
>
>
> Diff: https://reviews.apache.org/r/63958/diff/3/
>
>
> Testing
> -------
>
> Made sure that new tests added and all the older tests pass.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 9:09 p.m.)
Review request for sentry, Na Li and Sergio Pena.
Changes
-------
adddresed review comments.
Bugs: SENTRY-2034
https://issues.apache.org/jira/browse/SENTRY-2034
Repository: sentry
Description
-------
Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57134b20189aa10bee48f6aae765a1a1830
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java c8eef09ed61e11583838a3dfd3117a9478df23ba
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc354c3b4e5b21456ee9a471253ffa4624f17
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0
Diff: https://reviews.apache.org/r/63958/diff/3/
Changes: https://reviews.apache.org/r/63958/diff/2-3/
Testing
-------
Made sure that new tests added and all the older tests pass.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by Na Li via Review Board <no...@reviews.apache.org>.
> On Nov. 21, 2017, 8:37 p.m., Na Li wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java
> > Lines 81 (patched)
> > <https://reviews.apache.org/r/63958/diff/2/?file=1897928#file1897928line81>
> >
> > do you still need this? The previous grant is not removed.
>
> kalyan kumar kalvagadda wrote:
> there is only one grant for that DB. Which grant are you referring to?
line 65 has the same as line 81
statement.execute("grant select on database " + DB1 + " to role read_db1");
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/#review191638
-----------------------------------------------------------
On Dec. 5, 2017, 9:09 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63958/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 9:09 p.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2034
> https://issues.apache.org/jira/browse/SENTRY-2034
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57134b20189aa10bee48f6aae765a1a1830
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java c8eef09ed61e11583838a3dfd3117a9478df23ba
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc354c3b4e5b21456ee9a471253ffa4624f17
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0
>
>
> Diff: https://reviews.apache.org/r/63958/diff/3/
>
>
> Testing
> -------
>
> Made sure that new tests added and all the older tests pass.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/#review191638
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java
Lines 54 (patched)
<https://reviews.apache.org/r/63958/#comment269478>
could these functions be in base class TestHDFSIntegrationBase? They are in TestDbPrivilegeCleanupOnDrop also
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java
Lines 91 (patched)
<https://reviews.apache.org/r/63958/#comment269479>
Can we move this function to base too?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java
Lines 117 (patched)
<https://reviews.apache.org/r/63958/#comment269480>
We can combine these two into assertEqual(count, privilegeCount). If they are not equal, the exception will show the expected value and actual value.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java
Lines 90 (patched)
<https://reviews.apache.org/r/63958/#comment269482>
If HDFS sync is not enabled, HDFS does not get ACL from sync with sentry. how could HDFS gets acl in this case?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java
Lines 81 (patched)
<https://reviews.apache.org/r/63958/#comment269483>
do you still need this? The previous grant is not removed.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java
Lines 27-29 (patched)
<https://reviews.apache.org/r/63958/#comment269484>
We can avoid most duplicated code if you call "TestHDFSIntegrationBase.setup();" first, and then change the settings for each child class.
- Na Li
On Nov. 21, 2017, 12:27 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63958/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2017, 12:27 a.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2034
> https://issues.apache.org/jira/browse/SENTRY-2034
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 2138304
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 25a678b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc35
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f
>
>
> Diff: https://reviews.apache.org/r/63958/diff/2/
>
>
> Testing
> -------
>
> Made sure that new tests added and all the older tests pass.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/#review191619
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java
Lines 32-33 (patched)
<https://reviews.apache.org/r/63958/#comment269465>
What if you use a global boolean variable instead? Like:
useSyncOnCreate = true;
useSyncOnDrop = false;
and set those properties internally on the TestHDFSIntegrationBase? This code is repeated in several test files.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java
Lines 27-29 (patched)
<https://reviews.apache.org/r/63958/#comment269463>
What if you use a global boolean variable instead? Like:
useHdfsSync = true;
and set those properties internally on the TestHDFSIntegrationBase? This code is repeated in several test files.
- Sergio Pena
On Nov. 21, 2017, 12:27 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63958/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2017, 12:27 a.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2034
> https://issues.apache.org/jira/browse/SENTRY-2034
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 2138304
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 25a678b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc35
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f
>
>
> Diff: https://reviews.apache.org/r/63958/diff/2/
>
>
> Testing
> -------
>
> Made sure that new tests added and all the older tests pass.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/
-----------------------------------------------------------
(Updated Nov. 21, 2017, 12:27 a.m.)
Review request for sentry, Na Li and Sergio Pena.
Changes
-------
addressed review comments.
Bugs: SENTRY-2034
https://issues.apache.org/jira/browse/SENTRY-2034
Repository: sentry
Description
-------
Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 2138304
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 25a678b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc35
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f
Diff: https://reviews.apache.org/r/63958/diff/2/
Changes: https://reviews.apache.org/r/63958/diff/1-2/
Testing
-------
Made sure that new tests added and all the older tests pass.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by Na Li via Review Board <no...@reviews.apache.org>.
> On Nov. 20, 2017, 11:43 p.m., Sergio Pena wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
> > Lines 52-54 (patched)
> > <https://reviews.apache.org/r/63958/diff/1/?file=1897755#file1897755line52>
> >
> > Can we configure these properties in the same way other properties done by using global variables instead? This abstract test class needs some redesign and I don't like global variables, but to keep the configuration consistent, can we do it for these?
> >
> > Or, why aren't they just set by defalut on the TestHDFIntegrationBase?
sentryProperties contains several global properties. It is cleaner to keep them contained in sentryProperties instead of having bunch of global variables.
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/#review191546
-----------------------------------------------------------
On Nov. 21, 2017, 12:27 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63958/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2017, 12:27 a.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2034
> https://issues.apache.org/jira/browse/SENTRY-2034
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 2138304
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 25a678b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc35
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f
>
>
> Diff: https://reviews.apache.org/r/63958/diff/2/
>
>
> Testing
> -------
>
> Made sure that new tests added and all the older tests pass.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS
notification processing.
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/#review191546
-----------------------------------------------------------
I see you have different test cases per file and not per method, and I assume is because you call TestHDFSIntegrationBase.setup() on the @BeforeClass part. Why not calling it in the @Before part instead and put all the tests cases into one single file?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java
Lines 48 (patched)
<https://reviews.apache.org/r/63958/#comment269390>
method should start with lower case
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java
Lines 96-107 (patched)
<https://reviews.apache.org/r/63958/#comment269389>
If these tests are commented because they're not used, then we should remove them.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java
Lines 46 (patched)
<https://reviews.apache.org/r/63958/#comment269391>
method should start with lower case
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java
Lines 47 (patched)
<https://reviews.apache.org/r/63958/#comment269392>
method should start with lower case
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
Lines 198 (patched)
<https://reviews.apache.org/r/63958/#comment269387>
Why was this moved out of the createSentry() method? Isn't createSentry called only once on the @BeforeClass method? is it needed?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
Lines 52-54 (patched)
<https://reviews.apache.org/r/63958/#comment269388>
Can we configure these properties in the same way other properties done by using global variables instead? This abstract test class needs some redesign and I don't like global variables, but to keep the configuration consistent, can we do it for these?
Or, why aren't they just set by defalut on the TestHDFIntegrationBase?
- Sergio Pena
On Nov. 20, 2017, 4:25 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63958/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2017, 4:25 p.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2034
> https://issues.apache.org/jira/browse/SENTRY-2034
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 95bbaeb5a678ee4b1e7adaab9985346027ecfc24
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 3c8b70ec3db59a4e6de6a7fb8b1509c4fe228c25
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 645fc354c3b4e5b21456ee9a471253ffa4624f17
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java a911e2f50f63db6a99996ce44a74ad6bcc2a82b0
>
>
> Diff: https://reviews.apache.org/r/63958/diff/1/
>
>
> Testing
> -------
>
> Made sure that new tests added and all the older tests pass.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>