You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/07/21 20:33:44 UTC
[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #267: chore: Generalize option for static linking of Arrow C++ to link tests
paleolimbot opened a new pull request, #267:
URL: https://github.com/apache/arrow-nanoarrow/pull/267
The previous option to use static linking was just a test for `MSVC`; however, the may be other times where using a shared library fails (e.g., #254). This PR generalizes that option as a workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #267: chore: Generalize option for static linking of Arrow C++ to link tests
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #267:
URL: https://github.com/apache/arrow-nanoarrow/pull/267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] codecov-commenter commented on pull request #267: chore: Generalize option for static linking of Arrow C++ to link tests
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #267:
URL: https://github.com/apache/arrow-nanoarrow/pull/267#issuecomment-1646217904
## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/267?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#267](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/267?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b2122a1) into [main](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/efea22cc4eec237f004449420b6c7ee02732fb8f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (efea22c) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 87.19% 87.14% -0.05%
==========================================
Files 66 63 -3
Lines 10110 9750 -360
==========================================
- Hits 8815 8497 -318
+ Misses 1295 1253 -42
```
[see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/267/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org