You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/17 08:36:47 UTC

[GitHub] [flink] dawidwys opened a new pull request #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module

dawidwys opened a new pull request #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module
URL: https://github.com/apache/flink/pull/11789
 
 
   ## What is the purpose of the change
   
   Added junit 4 vintage engine to run junit 4 tests in junit 5 environment.
   
   ## Verifying this change
   
   Execute `mvn clean install` in `flink-sql-parser` module. Check these tests are executed:
   * org.apache.flink.sql.parser.TableApiIdentifierParsingTest
   * org.apache.flink.sql.parser.FlinkDDLDataTypeTest
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (**yes** / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module
URL: https://github.com/apache/flink/pull/11789#issuecomment-615133832
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f5e3e1b844e599e30f5f42e46dc8e6bf8d8b8cb2",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160697066",
       "triggerID" : "f5e3e1b844e599e30f5f42e46dc8e6bf8d8b8cb2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f5e3e1b844e599e30f5f42e46dc8e6bf8d8b8cb2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7647",
       "triggerID" : "f5e3e1b844e599e30f5f42e46dc8e6bf8d8b8cb2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f5e3e1b844e599e30f5f42e46dc8e6bf8d8b8cb2 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160697066) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7647) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys commented on issue #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module

Posted by GitBox <gi...@apache.org>.
dawidwys commented on issue #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module
URL: https://github.com/apache/flink/pull/11789#issuecomment-615120905
 
 
   cc @danny0405 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys merged pull request #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module

Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module
URL: https://github.com/apache/flink/pull/11789
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module
URL: https://github.com/apache/flink/pull/11789#issuecomment-615123995
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit f5e3e1b844e599e30f5f42e46dc8e6bf8d8b8cb2 (Fri Apr 17 08:44:53 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11789: [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module
URL: https://github.com/apache/flink/pull/11789#issuecomment-615133832
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f5e3e1b844e599e30f5f42e46dc8e6bf8d8b8cb2",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160697066",
       "triggerID" : "f5e3e1b844e599e30f5f42e46dc8e6bf8d8b8cb2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f5e3e1b844e599e30f5f42e46dc8e6bf8d8b8cb2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7647",
       "triggerID" : "f5e3e1b844e599e30f5f42e46dc8e6bf8d8b8cb2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f5e3e1b844e599e30f5f42e46dc8e6bf8d8b8cb2 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160697066) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7647) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services