You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2015/12/03 10:44:55 UTC

Review Request 40901: Ambari File View: Warning does not go away

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40901/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-14173
    https://issues.apache.org/jira/browse/AMBARI-14173


Repository: ambari


Description
-------

added showError property and resetting it after successful operation example - rename operation. Using the same property before showing the error message.


Diffs
-----

  contrib/views/files/src/main/resources/ui/app/controllers/file.js b5054e4 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js 7fb55bd 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 3d4af71 

Diff: https://reviews.apache.org/r/40901/diff/


Testing
-------

mvn clean install

Here are build logs:

-------------------------------------------------------
 T E S T S
-------------------------------------------------------

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.filebrowser.FilebrowserTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.157 sec

Results :

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0

[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .git/
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.gitattributes
[INFO] Exclude: .idea/
[INFO] Exclude: pass.txt
[INFO] Exclude: .DS_Store
[INFO] Exclude: .iml/
[INFO] Exclude: .classpath
[INFO] Exclude: .project
[INFO] Exclude: .settings
[INFO] Exclude: **/target/**
[INFO] Exclude: **/.gitkeep
[INFO] Exclude: **/.bowerrc
[INFO] Exclude: **/.editorconfig
[INFO] Exclude: **/.jshintrc
[INFO] Exclude: **/.tmp/**
[INFO] Exclude: **/tmp/**
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/bin
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/public/**
[INFO] Exclude: **/dist/**
[INFO] Exclude: **/bower_components/**
[INFO] Exclude: **/bower/**
[INFO] Exclude: **/node/**
[INFO] Exclude: **/runner.js
[INFO] Exclude: **/assets/javascripts/**
[INFO] Exclude: **/assets/stylesheets/**
[INFO] Exclude: **/assets/static/javascripts/**
[INFO] Exclude: **/assets/static/stylesheets/**
[INFO] Exclude: storm/src/main/resources/**
[INFO] 77 resources included (use -debug for more details)
Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Compiler warnings:
  WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 71 licence.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
[INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
[INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
[INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
[INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:15.847s
[INFO] Finished at: Thu Dec 03 15:00:14 IST 2015
[INFO] Final Memory: 50M/821M
[INFO] ------------------------------------------------------------------------


Thanks,

Pallav Kulshreshtha


Re: Review Request 40901: Ambari File View: Warning does not go away

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40901/#review108821
-----------------------------------------------------------

Ship it!


Ship It!

- DIPAYAN BHOWMICK


On Dec. 3, 2015, 9:44 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40901/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 9:44 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14173
>     https://issues.apache.org/jira/browse/AMBARI-14173
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> added showError property and resetting it after successful operation example - rename operation. Using the same property before showing the error message.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js b5054e4 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js 7fb55bd 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs 3d4af71 
> 
> Diff: https://reviews.apache.org/r/40901/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> Here are build logs:
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.filebrowser.FilebrowserTest
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.157 sec
> 
> Results :
> 
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ files ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .git/
> [INFO] Exclude: **/.gitignore
> [INFO] Exclude: **/.gitattributes
> [INFO] Exclude: .idea/
> [INFO] Exclude: pass.txt
> [INFO] Exclude: .DS_Store
> [INFO] Exclude: .iml/
> [INFO] Exclude: .classpath
> [INFO] Exclude: .project
> [INFO] Exclude: .settings
> [INFO] Exclude: **/target/**
> [INFO] Exclude: **/.gitkeep
> [INFO] Exclude: **/.bowerrc
> [INFO] Exclude: **/.editorconfig
> [INFO] Exclude: **/.jshintrc
> [INFO] Exclude: **/.tmp/**
> [INFO] Exclude: **/tmp/**
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.svg
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/bin
> [INFO] Exclude: **/node_modules/**
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/public/**
> [INFO] Exclude: **/dist/**
> [INFO] Exclude: **/bower_components/**
> [INFO] Exclude: **/bower/**
> [INFO] Exclude: **/node/**
> [INFO] Exclude: **/runner.js
> [INFO] Exclude: **/assets/javascripts/**
> [INFO] Exclude: **/assets/stylesheets/**
> [INFO] Exclude: **/assets/static/javascripts/**
> [INFO] Exclude: **/assets/static/stylesheets/**
> [INFO] Exclude: storm/src/main/resources/**
> [INFO] 77 resources included (use -debug for more details)
> Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
>   WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 71 licence.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ files ---
> [INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ files ---
> [INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
> [INFO]
> [INFO] --- maven-install-plugin:2.4:install (default-install) @ files ---
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/target/files-1.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.jar
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/files/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/files/1.0.0.0-SNAPSHOT/files-1.0.0.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:15.847s
> [INFO] Finished at: Thu Dec 03 15:00:14 IST 2015
> [INFO] Final Memory: 50M/821M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>