You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/28 00:02:49 UTC

[GitHub] [beam] lostluck commented on pull request #12046: [BEAM-10290] Add a unit(ish) test for dynamic splitting correctness.

lostluck commented on pull request #12046:
URL: https://github.com/apache/beam/pull/12046#issuecomment-650652032


   Just for completenes, since we chatted offline: I didn't miss this. I think these are good tests, that just need the rest of the implementation, already partly plumbed in (the now merged) https://github.com/apache/beam/pull/12095. It's AOK if this PR is updated with the remaining implementation details, or if it's easier, to close this one, and use it's content in a separate PR..


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org