You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rubenfiszel <gi...@git.apache.org> on 2018/05/15 15:47:47 UTC
[GitHub] spark pull request #21334: Improve ParseError stop location when offending s...
GitHub user rubenfiszel opened a pull request:
https://github.com/apache/spark/pull/21334
Improve ParseError stop location when offending symbol is a token
In the case where the offending symbol is a CommonToken, this PR increases the accuracy of the start and stop origin by leveraging the start and stop index information from CommonToken.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rubenfiszel/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21334
----
commit a870c394e80277f4f059eb288f30c707e0fc04f5
Author: Ruben Fiszel <ru...@...>
Date: 2018-05-15T15:45:23Z
Improve ParseErrorListener range accuracy when offending symbol is a token
In the case where the offending symbol is a CommonToken, this PR increases the accuracy of the start and stop origin by leveraging the start and stop index information from CommonToken.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21334: [minor][SQL]Improve ParseError stop location when offend...
Posted by ash211 <gi...@git.apache.org>.
Github user ash211 commented on the issue:
https://github.com/apache/spark/pull/21334
Hi @rubenfiszel thanks for the contribution! Can you please take a glance through http://spark.apache.org/contributing.html to see the best way to get your change merged into Apache Spark?
I'd suggest you:
- file an issue at https://issues.apache.org/jira/projects/SPARK and put that in the PR title
- include a test that verifies the fix is working as you expect
Cheers!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21334: [SPARK-24345][SQL]Improve ParseError stop location when ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21334
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21334: [SPARK-24345][SQL]Improve ParseError stop location when ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21334
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21334: [minor][SQL]Improve ParseError stop location when offend...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21334
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21334: [minor][SQL]Improve ParseError stop location when offend...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21334
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21334: [SPARK-24345][SQL]Improve ParseError stop location when ...
Posted by rubenfiszel <gi...@git.apache.org>.
Github user rubenfiszel commented on the issue:
https://github.com/apache/spark/pull/21334
@ash211 As requested, implemented tests and created the associated ticket
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org